952952 - pdf viewer should have a 'find in document' button, or search box

Status: RESOLVED DUPLICATE of bug 951610

(Firefox :: PDF Viewer, defect)

Description

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Find functionality works fine, but is poorly surfaced.  

Proposed solution:
- 'find' (spyglass) icon in pdfjs viewer, which triggers fine.

Comment 1

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Observations:
- there is a find button already implemented!  (but hidden, unless 'supportsIntegratedFind')
- The normal page findbar seems not to work on pdfjs content
- `PDFView.supportsIntegratedFind()` is true, but the button still has 'hidden'.  Maybe DOMContentLoaded is too early?



(Interactive experimentation:
jar:file:///Applications/FirefoxAurora.app/Contents/MacOS/browser/omni.ja!/chrome/pdfjs/content/web/viewer.html
source:  /browser/extensions/pdfjs)

Comment 2

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Attachment: WIP, find icon should show when integratedSearch is supported, not reverse

I am not sure that I am understanding what 'integratedSearch' means here.  

Even when *this find* is enabled, the "firefox search in page" captures (eats) Cntl-F captures.  This seems weird.

Comment 3

[Yury Delendik (:yury)]

Find functionality in the integrated PDF Viewer exposed via standard Firefox find bar. The search commands from the Firefox find bar are handled in the viewer. There is no need to use find toolbar implemented in pdf.js to do that.

Comment 4

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

I literally watched a user who was unable to search their pdf, because they were expecting a spyglass icon in pdfjs, as exists in both Preview and Acrobat.  

The icon code exists, but is not exposed (css hidden). 

If the firefox find works, then re-eventing the pdfjs viewer spyglass to trigger `cmd_find` is a fine solution.