Closed
Bug 952954
Opened 11 years ago
Closed 11 years ago
Need to update plugin placeholder visibility code
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.26
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(2 files)
|
5.48 KB,
patch
|
mcsmurf
:
review+
|
Details | Diff | Splinter Review |
|
15.62 KB,
patch
|
Details | Diff | Splinter Review |
Bug 853973 changed the way the placeholder was hidden. The new way to override it is to update the visible class instead of the visibility style.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
This fixes the plugin click-to-play tests (though atm the mochitests do not finish due to the "let sidebar = document.getElementById("sidebar");" code in browser-test.js added in Bug 932898, but that needs to be solved in a new bug).
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8351222 [details] [diff] [review]
Proposed patch
Patch works fine, almost all tests pass (and those that don't pass are not related to this code change)
Attachment #8351222 -
Flags: review?(bugzilla) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.26
You need to log in
before you can comment on or make changes to this bug.
Description
•