Closed Bug 952954 Opened 7 years ago Closed 7 years ago

Need to update plugin placeholder visibility code

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.26

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(2 files)

Bug 853973 changed the way the placeholder was hidden. The new way to override it is to update the visible class instead of the visibility style.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8351222 - Flags: review?(bugzilla)
Attached patch Test fixSplinter Review
This fixes the plugin click-to-play tests (though atm the mochitests do not finish due to the "let sidebar = document.getElementById("sidebar");" code in browser-test.js added in Bug 932898, but that needs to be solved in a new bug).
Comment on attachment 8351222 [details] [diff] [review]
Proposed patch

Patch works fine, almost all tests pass (and those that don't pass are not related to this code change)
Attachment #8351222 - Flags: review?(bugzilla) → review+
Pushed comm-central changeset df2467f3dc22.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.26
You need to log in before you can comment on or make changes to this bug.