952963 - areaType getter in widget wrapper assumes area exists

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Luís Miguel [:quicksaver] (not reading bugmail)]

At http://mxr.mozilla.org/mozilla-central/source/browser/components/customizableui/src/CustomizableUI.jsm#2891:

> 2891   this.__defineGetter__("areaType", function() {
> 2892     return gAreas.get(aWidget.currentArea).get("type");
> 2893   });

If I call CUI.getWidget(someID).areaType, it will throw a TypeError if the widget has no area (is in the palette) or is "placed" in a custom toolbar that has been unregistered.

Simple example, make that call from the browser console, using an id from any widget in the palette.

There should be a fail-safe that returns either null for this, just like the one in http://mxr.mozilla.org/mozilla-central/source/browser/components/customizableui/src/CustomizableUI.jsm#2987:

> 2987   this.__defineGetter__("areaType", function() {
> 2988     let placement = CustomizableUIInternal.getPlacementOfWidget(aWidgetId);
> 2989     if (!placement) {
> 2990       return null;
> 2991     }
> 2992 
> 2993     return gAreas.get(placement.area).get("type");
> 2994   });

Comment 1

[Luís Miguel [:quicksaver] (not reading bugmail)]

Addendum: There should be a fail-safe that returns null in this case [...]

Comment 2

[:Gijs (he/him)]

Attachment: areaType getter in widget wrapper shouldn't assume area exists,

This should do.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8355157 [details] [diff] [review]
areaType getter in widget wrapper shouldn't assume area exists,

Review of attachment 8355157 [details] [diff] [review]:
-----------------------------------------------------------------

A test here would be nice.

Comment 4

[:Gijs (he/him)]

Landed with test:

https://hg.mozilla.org/integration/fx-team/rev/4bc1cf097ca1

and then promptly backed out and relanded to fix the commit msg to have "Australis":

https://hg.mozilla.org/integration/fx-team/rev/52d2bc346659
https://hg.mozilla.org/integration/fx-team/rev/3f3b0a504f65

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4bc1cf097ca1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/52d2bc346659