952970 - Revisit proxy implementation for Android

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Richard Newman [:rnewman]]

The Java stock ProxySelect implementation isn't all that compatible, perf-wise, with Gecko's proxy lookups. See Bug 952799 Comment 4. We hacked around that by memoizing the expensive path, but we're still having to instantiate URIs when we don't want to, as well as making a JNI call and all the rest on every new network connection.

Furthermore, we probably want to have proxy configuration within the browser. It's more discoverable that way. (I can't even find proxy settings on my HTC One.)

And finally, we ought to use the same proxy configuration for our background code (Bug 507641).

Those three things imply that we should build a settings UI and a proxy manager (with the option to delegate to the Android proxy stack?), writing through to Gecko. That would handily avoid the need to call into GeckoAppShell for a proxy lookup entirely, and offer a better UX to boot.

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.