952993 - Screen isn't wrapping all the way to the top when using the OSK to search for next instance

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: Top of screen being cut off when searching using OSK

When using the OSK to search for the next instances of the word using Find App Bar, the screen will not wrap all the way to the top once you have reached the bottom. This creates a situation where a "found word" is not displayed because its being cut off.

- Attached a screenshot to illustrate the issue

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Values,_variables,_and_literals
3) Once the article has been loaded, slide in the Navigation App Bar and select "Settings -> Find in page"
4) Tap on the text box on the Find App Bar and the OSK should appear
5) Using the OSK, type in "javascript"
6) Once you have typed the word using the OSK, select "Search"
7) Search through all the words and you'll notice that once it wraps back to the top, the selected "javascript" will not be visible

Current Behaviour:

- Screen is not wrapping all the way to the top and cutting off the words that have been found near the top of the screen (you wont see the selected word)

Expected Behaviour:

- Screen should wrap around all the way to the top and then start scrolling down when the user starts using the "Search" button on the OSK

Found the bug using the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-22-03-02-04-mozilla-central/

Comment 1

[Jim Mathies [:jimm]]

Attachment: test case ('finder')

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 8359752 [details] [diff] [review]
fix

Review of attachment 8359752 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine.

Comment 4

[Jim Mathies [:jimm]]

Attachment: export

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b94cec8a6670

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b94cec8a6670

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/71353423c327

Comment 8

[u279076]

Kamil, please verify this is fixed in the latest Nightly and Aurora.

Comment 9

[Manuela Muntean [Away]]

Verified as fixed for iteration #22, with both latest Nightly and Aurora on Surface pro 2 with Windows 8.1 64-bit.