953048 - Browse the Firefox Marketplace in about:apps links to about:blank

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Firefox Nightly 29.0a1 (2013-12-23)
Galaxy Tab (Android 4.0.4)
Galaxy Nexus (android 4.3)

Steps to reproduce:
1. Go to Settings -> Tools and choose Apps
2. Tap the Browse the Firefox Marketplace 

Expected results:
- http://marketplace.firefox.com/ should be loaded

Actual result:
- about: blank page is loaded

Comment 1

[Ioana Chiorean]

Good build: 1387413905 http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android/1387413905/
Bad build: 1387420142 http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-inbound-android/1387420142/
Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=86eb809847a3&tochange=f6588099c40b

Maybe 	337c0ae0b790	Frederik Braun — Bug 948894 - Move inline scripts for about:apps into AboutApps.js. r=mleibovic is the cause.

Comment 2

[Aaron Train [:aaronmt]]

Re: bug 948894? Can you guys reproduce this? Is this related to that bug?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds like Myk has a fix in bug 953328

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Re: bug 948894? Can you guys reproduce this? Is this related to that bug?

I can reproduce it.  And it is indeed caused by that bug.  I'll isolate the fix in bug 953328 and attach it here.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Attachment: 953048v1.diff

The regressing bug refactors both of the Marketplace affordances (the header button and the list item) to use the same openLink event handler, which accesses the app.marketplaceURL pref via the Event.target property.

But the list item has inner content, and Event.target references that inner content when you tap the list item's label, so openLink can't get the URL to open.

This patch makes openLink use Event.currentTarget to reference the correct element for both the header button (where it references the same element as Event.target) and the list item.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8354921 [details] [diff] [review]
953048v1.diff

Thanks Myk

Comment 7

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fbaaeeb5ab4f

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fbaaeeb5ab4f

Comment 9

[Ioana Chiorean]

Firefox Nightly 29.0a1 (2013-12-23)
Galaxy Nexus (android 4.3)

Using the reported steps this is no longer reproducing. The marketplace page loads correctly.

Setting bug to Verified Fixed,