953054 - Feed view has unreadable line if using dark theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexander Usyskin]

When viewing rss feed in Firefox (26.0 and Nightly 29) on Linux using dark theme (MediterraneanDarkest in my case) the subtitle of feed is rendered black-on-darkgray.
The problem that h2 entry for feed view uses following rule from
chrome://browser/skin/feeds/subscribe.css:90

h2 {
  color: ThreeDDarkShadow;
  font-size: 110%;
  font-weight: normal;
  margin: 0 0 .6em 0;
}

ThreeDDarkShadow color not intended to use as text color, IMO there must be another color, like -moz-fieldText.

Comment 1

[Dão Gottwald [:dao]]

We could either just drop the color for that rule or use GrayText.

This affects both browser/themes/linux/feeds/subscribe.css and browser/themes/windows/feeds/subscribe.css.

Since OS X doesn't support dark OS themes, we don't need to worry about that.

Comment 2

[Seif Lotfy]

I will be working on this bug. Should be straight forward

Comment 3

[gillh11]

Can I have this bug assigned to me

Comment 4

[Dão Gottwald [:dao]]

(In reply to gillh11 from comment #3)
> Can I have this bug assigned to me

Seif said in comment 2 he wanted to work on it. Any update, Seif?

Comment 5

[Seif Lotfy]

Please assign the bug to gillh11 :D. I fixed 2 other bugs forgot about this one :(

Comment 6

[Dão Gottwald [:dao]]

gillh11, do you still want to work on this?

Comment 7

[AdityaSingh [:MacroMayhem]]

I'd like to work on this ? can you guide me through the process ?

Comment 8

[Dão Gottwald [:dao]]

(In reply to AdityaSingh [:MacroMayhem] from comment #7)
> I'd like to work on this ? can you guide me through the process ?

Hi. Do you already have the source code? Have you built Firefox?

Comment 9

[AdityaSingh [:MacroMayhem]]

(In reply to Dão Gottwald [:dao] from comment #8)
> (In reply to AdityaSingh [:MacroMayhem] from comment #7)
> > I'd like to work on this ? can you guide me through the process ?
> 
> Hi. Do you already have the source code? Have you built Firefox?

Yes, I have the source code and have built it.

Comment 10

[Dão Gottwald [:dao]]

Ok. Do you understand what I said in comment 1?

Comment 11

[AdityaSingh [:MacroMayhem]]

I guess so, the color field in the definition is creating problem and that you want it to be another color?

Comment 12

[Dão Gottwald [:dao]]

Yes. We should either use GrayText as the color or not specify a color at all there. I'll leave that choice to you.

You can test the result by loading <http://planet.mozilla.org/rss20.xml>.

Comment 13

[AdityaSingh [:MacroMayhem]]

Attachment: 953054-v1.patch fixes the color compatibility

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 8385091 [details] [diff] [review]
953054-v1.patch fixes the color compatibility

Looks fine, thanks!

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/eeb4c66e6091

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eeb4c66e6091

Comment 17

[Alexander Usyskin]

Thanks! Working fine now.

Comment 18

[Andrei Vaida [:avaida]]

This issue was verified fixed on Ubuntu 12.04 32-bit [1], using:
- the latest Aurora (Build ID: 20140422004001),
- the latest Nightly (Build ID: 20140422030204).

1. Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0