Closed Bug 953054 Opened 6 years ago Closed 6 years ago

Feed view has unreadable line if using dark theme

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 30

People

(Reporter: sanniu, Assigned: MacroMayhem)

Details

(Whiteboard: [good first bug][lang=css][mentor=dao])

Attachments

(1 file)

When viewing rss feed in Firefox (26.0 and Nightly 29) on Linux using dark theme (MediterraneanDarkest in my case) the subtitle of feed is rendered black-on-darkgray.
The problem that h2 entry for feed view uses following rule from
chrome://browser/skin/feeds/subscribe.css:90

h2 {
  color: ThreeDDarkShadow;
  font-size: 110%;
  font-weight: normal;
  margin: 0 0 .6em 0;
}

ThreeDDarkShadow color not intended to use as text color, IMO there must be another color, like -moz-fieldText.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86_64 → All
We could either just drop the color for that rule or use GrayText.

This affects both browser/themes/linux/feeds/subscribe.css and browser/themes/windows/feeds/subscribe.css.

Since OS X doesn't support dark OS themes, we don't need to worry about that.
Whiteboard: [good first bug][lang=css][mentor=dao]
I will be working on this bug. Should be straight forward
Can I have this bug assigned to me
(In reply to gillh11 from comment #3)
> Can I have this bug assigned to me

Seif said in comment 2 he wanted to work on it. Any update, Seif?
Flags: needinfo?(seif)
Please assign the bug to gillh11 :D. I fixed 2 other bugs forgot about this one :(
Flags: needinfo?(seif)
Assignee: nobody → gillh11
gillh11, do you still want to work on this?
Flags: needinfo?(gillh11)
I'd like to work on this ? can you guide me through the process ?
(In reply to AdityaSingh [:MacroMayhem] from comment #7)
> I'd like to work on this ? can you guide me through the process ?

Hi. Do you already have the source code? Have you built Firefox?
Assignee: gillh11 → aditya.91.singh
Flags: needinfo?(gillh11)
(In reply to Dão Gottwald [:dao] from comment #8)
> (In reply to AdityaSingh [:MacroMayhem] from comment #7)
> > I'd like to work on this ? can you guide me through the process ?
> 
> Hi. Do you already have the source code? Have you built Firefox?

Yes, I have the source code and have built it.
Ok. Do you understand what I said in comment 1?
I guess so, the color field in the definition is creating problem and that you want it to be another color?
Yes. We should either use GrayText as the color or not specify a color at all there. I'll leave that choice to you.

You can test the result by loading <http://planet.mozilla.org/rss20.xml>.
Comment on attachment 8385091 [details] [diff] [review]
953054-v1.patch fixes the color compatibility

Looks fine, thanks!
Attachment #8385091 - Flags: feedback?(dao) → review+
https://hg.mozilla.org/integration/fx-team/rev/eeb4c66e6091
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css][mentor=dao] → [good first bug][lang=css][mentor=dao][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/eeb4c66e6091
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][mentor=dao][fixed-in-fx-team] → [good first bug][lang=css][mentor=dao]
Target Milestone: --- → Firefox 30
Thanks! Working fine now.
Keywords: verifyme
This issue was verified fixed on Ubuntu 12.04 32-bit [1], using:
- the latest Aurora (Build ID: 20140422004001),
- the latest Nightly (Build ID: 20140422030204).

1. Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.