953073 - [AccessFu] List bullet should appear before context utterance in braille

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Max Li [:maxli]]

For example, a listitem that is a link should have the braille "* lnk linktext" and not "lnk * linktext".

Comment 1

[Max Li [:maxli]]

Attachment: Patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8351403 [details] [diff] [review]
Patch

Review of attachment 8351403 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/OutputGenerator.jsm
@@ +689,5 @@
> +    if (acc.indexInParent === 1 &&
> +        acc.parent.role == Roles.LISTITEM &&
> +        acc.previousSibling.role == Roles.STATICTEXT) {
> +      if (acc.parent.parent && acc.parent.parent.DOMNode &&
> +          acc.parent.parent.DOMNode.nodeName == 'UL') {

I'm curious why UL is special, having a dependency on tag names is rather a bad practice since you don't take into account styles

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to alexander :surkov from comment #2)
> Comment on attachment 8351403 [details] [diff] [review]
> Patch
> 
> Review of attachment 8351403 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/jsat/OutputGenerator.jsm
> @@ +689,5 @@
> > +    if (acc.indexInParent === 1 &&
> > +        acc.parent.role == Roles.LISTITEM &&
> > +        acc.previousSibling.role == Roles.STATICTEXT) {
> > +      if (acc.parent.parent && acc.parent.parent.DOMNode &&
> > +          acc.parent.parent.DOMNode.nodeName == 'UL') {
> 
> I'm curious why UL is special, having a dependency on tag names is rather a
> bad practice since you don't take into account styles

I think we already do that elsewhere, but that is not an excuse. Max, what about the case where it is OL? Wouldn't we want the same outcome?

Comment 4

[Eitan Isaacson [:eeejay]]

Comment on attachment 8351403 [details] [diff] [review]
Patch

Removing review flag until the question above is answered.

Comment 5

[Max Li [:maxli]]

Comment on attachment 8351403 [details] [diff] [review]
Patch

(In reply to Eitan Isaacson [:eeejay] from comment #3)
> > I'm curious why UL is special, having a dependency on tag names is rather a
> > bad practice since you don't take into account styles
> 
> I think we already do that elsewhere, but that is not an excuse. Max, what
> about the case where it is OL? Wouldn't we want the same outcome?

If by same outcome you mean replacing the static text, I don't think it is necessary. Replacing it in unordered lists is done because otherwise the static text is non-ascii which produces strange output (and if I recall correctly inconsistent with native Android behaviour). In the ordered list case, the bullets are all ascii (e.g. decimal numbers, roman numerals, or alphabetic), so I think it's okay to keep them and this preserves more information. Moreover, I think the dependency on tag names is necessary, since (I think) there's no ability to determine orderedness strictly from the accessibility side. Styles aren't entirely relevant because the braille is more like a visual output of semantics, and not really a pure visual representation of the screen.

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 8351403 [details] [diff] [review]
Patch

I agree with max's assessment that bullets for list items should always come first. Also, it is OK to translate these. Some screen readers even translate different unicode bullets to different braille and speech symbols/spoken words. Many synths can't deal with those unicode symbols anyway.

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 8351403 [details] [diff] [review]
Patch

Review of attachment 8351403 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks for the patch and info.

Comment 8

[Max Li [:maxli]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7bce3f674b53

Comment 9

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/7bce3f674b53