js/src/jit/FixedList.h: warning: field 'length_' will be initialized after field 'list_' [-Wreorder]

RESOLVED FIXED in mozilla29

Status

()

Core
JavaScript Engine: JIT
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

Trunk
mozilla29
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 8351468 [details] [diff] [review]
fix-Wreorder-warning.patch

Bug 950716 introduced a -Wreorder warning for clang on OS X:

Warning: -Wreorder in mozilla/inbound/js/src/jit/FixedList.h: field 'length_' will be initialized after field 'list_'
mozilla/inbound/js/src/jit/FixedList.h:31:9: warning: field 'length_' will be initialized after field 'list_' [-Wreorder]
       : length_(0), list_(nullptr)
Attachment #8351468 - Flags: review?(nicolas.b.pierron)
Attachment #8351468 - Flags: review?(nicolas.b.pierron) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/07f7597000b7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Fixed = m-c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Yeah, but it was fixed by a no-bug push, so unless I happened to see firebot mentioning it being marked fixed and was curious, I wouldn't have known to mark it when I merged the no-bug push...
https://hg.mozilla.org/mozilla-central/rev/07f7597000b7
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.