Note: There are a few cases of duplicates in user autocompletion which are being worked on.

ckfw should support cipher operations.

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P3
normal
RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: zhoubin, Assigned: Robert Relyea)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

16 years ago
I'm write pkcs11 module using nss's ckfw.But ckfw does not support cipher 
operations,such as digest,sign.(the wrapped function's implementation is empty).

Comment 1

16 years ago
Assigned the bug to Bob.
Assignee: wtc → relyea
(Assignee)

Comment 2

16 years ago
Yup, that's on the list.;).

bob
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

16 years ago
Bob, I assume you plan to address this issue in NSS 3.4?
Priority: -- → P1
Target Milestone: --- → 3.4
Version: unspecified → 3.3.1
(Assignee)

Comment 4

16 years ago
It would be nice, but I really think it's a 4.0 feature.

I'm using the softoken in 3.4

bob

Updated

16 years ago
Priority: P1 → P3

Updated

16 years ago
Target Milestone: 3.4 → 4.0

Comment 5

16 years ago
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee
QA Contact: bishakhabanerjee → jason.m.reid
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 6

12 years ago
Created attachment 201870 [details] [diff] [review]
Implement the basic Cryptographic operations needed for a typical readonly 'smart card'

This patch implments all the XXXXX_Init XXXXX_Update XXXXXX_Final and XXXXX (update and final) as well as the combo operations.

It does not implement the basic key operations: wrap, unwrap, keygen, etc.
The basic flow is the token returns mechanism structures for each mechanism it implements. These structures supply the XXXX_Init operations, which return a CryptoOperation structure. The latter is stored in PKCS #11 by class (as the PKCS #11 spec specifies), and are used to fulfill the subsequent update, updateDigest final, etc operations.

bob
Attachment #201870 - Flags: review?
(Assignee)

Comment 7

12 years ago
The patch is long, but very repetitive.
(Assignee)

Comment 8

12 years ago
set target milestone.
Target Milestone: 4.0 → 3.11

Updated

12 years ago
Attachment #201870 - Flags: review? → review?(julien.pierre.bugs)
(Assignee)

Comment 9

12 years ago
Created attachment 203033 [details] [diff] [review]
Complete the needed framework functions.

Here is the 'final' patch. I'm sure we will need to make updates as this code gets more use, but this should provide a good base usage for implementing tokens which do crypto.

this patch is needed for the capi pkcs #11 module to build.
Attachment #201870 - Attachment is obsolete: true
Attachment #201870 - Flags: review?(julien.pierre.bugs)
Attachment #203033 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #203033 - Flags: superreview?(kengert)
Attachment #203033 - Flags: review?(julien.pierre.bugs)
Attachment #203033 - Flags: review?

Comment 10

12 years ago
Comment on attachment 203033 [details] [diff] [review]
Complete the needed framework functions.

You are often derefencing pointers without having checked for null. Please decide yourself whether you want to add some checks.
Attachment #203033 - Flags: superreview?(kengert) → superreview+
(Assignee)

Updated

12 years ago
Attachment #203033 - Flags: review?(julien.pierre.bugs)
(Assignee)

Comment 11

12 years ago
Created attachment 208039 [details] [diff] [review]
Turn off capi builds unless an NSS_BUILD_CAPI is set, or MOZILLA_CLIENT is set

Patch to allow older window developement environments to continue to build NSS.
Attachment #208039 - Flags: review?
(Assignee)

Comment 12

12 years ago
Comment on attachment 208039 [details] [diff] [review]
Turn off capi builds unless an NSS_BUILD_CAPI is set, or MOZILLA_CLIENT is set

Oops, I guess I forgot to put Julien on the review.

bob
Attachment #208039 - Flags: review? → review?(julien.pierre.bugs)

Updated

12 years ago
Attachment #208039 - Flags: review?(julien.pierre.bugs) → review+
QA Contact: jason.m.reid → libraries
(Assignee)

Comment 13

10 years ago
Comment on attachment 203033 [details] [diff] [review]
Complete the needed framework functions.

This bug just needs a second review. The patch has been in NSS 3.12 for ages.

Alexi, feel free to punt the review to someone else if you are loaded.

bob
Attachment #203033 - Flags: review?(alexei.volkov.bugs)
(Assignee)

Updated

10 years ago
Target Milestone: 3.11 → 3.11.7
Bob, out of curiosity, what/who needs this before 3.12?
(Assignee)

Comment 15

10 years ago
rob can use it. I wouldn't say it is critical.

Mostly, I misunderstood target email, and thought it was the list of things that were targetted for 3.11.7. After I realized the truth, I also realized that this would be a nice have.

It's not a high priority item.

bob
(Assignee)

Comment 16

10 years ago
Comment on attachment 203033 [details] [diff] [review]
Complete the needed framework functions.

we don't really need this in 3.11.x. dropping review request.
Attachment #203033 - Flags: review?(alexei.volkov.bugs)
Agreed.
Target Milestone: 3.11.7 → 3.12

Comment 18

10 years ago
So, should this bug be resolved fixed then ?
(Assignee)

Comment 19

10 years ago
yes.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.