95323 - ckfw should support cipher operations.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[zhoubin]

I'm write pkcs11 module using nss's ckfw.But ckfw does not support cipher 
operations,such as digest,sign.(the wrapped function's implementation is empty).

Comment 1

[Wan-Teh Chang]

Assigned the bug to Bob.

Comment 2

[Robert Relyea]

Yup, that's on the list.;).

bob

Comment 3

[Wan-Teh Chang]

Bob, I assume you plan to address this issue in NSS 3.4?

Comment 4

[Robert Relyea]

It would be nice, but I really think it's a 4.0 feature.

I'm using the softoken in 3.4

bob

Comment 5

[Wan-Teh Chang]

Changed the QA contact to Bishakha.

Comment 6

[Robert Relyea]

Attachment: Implement the basic Cryptographic operations needed for a typical readonly 'smart card'

This patch implments all the XXXXX_Init XXXXX_Update XXXXXX_Final and XXXXX (update and final) as well as the combo operations.

It does not implement the basic key operations: wrap, unwrap, keygen, etc.
The basic flow is the token returns mechanism structures for each mechanism it implements. These structures supply the XXXX_Init operations, which return a CryptoOperation structure. The latter is stored in PKCS #11 by class (as the PKCS #11 spec specifies), and are used to fulfill the subsequent update, updateDigest final, etc operations.

bob

Comment 7

[Robert Relyea]

The patch is long, but very repetitive.

Comment 8

[Robert Relyea]

set target milestone.

Comment 9

[Robert Relyea]

Attachment: Complete the needed framework functions.

Here is the 'final' patch. I'm sure we will need to make updates as this code gets more use, but this should provide a good base usage for implementing tokens which do crypto.

this patch is needed for the capi pkcs #11 module to build.

Comment 10

[Kai Engert [:KaiE:]]

Comment on attachment 203033 [details] [diff] [review]
Complete the needed framework functions.

You are often derefencing pointers without having checked for null. Please decide yourself whether you want to add some checks.

Comment 11

[Robert Relyea]

Attachment: Turn off capi builds unless an NSS_BUILD_CAPI is set, or MOZILLA_CLIENT is set

Patch to allow older window developement environments to continue to build NSS.

Comment 12

[Robert Relyea]

Comment on attachment 208039 [details] [diff] [review]
Turn off capi builds unless an NSS_BUILD_CAPI is set, or MOZILLA_CLIENT is set

Oops, I guess I forgot to put Julien on the review.

bob

Comment 13

[Robert Relyea]

Comment on attachment 203033 [details] [diff] [review]
Complete the needed framework functions.

This bug just needs a second review. The patch has been in NSS 3.12 for ages.

Alexi, feel free to punt the review to someone else if you are loaded.

bob

Comment 14

[Nelson Bolyard (seldom reads bugmail)]

Bob, out of curiosity, what/who needs this before 3.12?

Comment 15

[Robert Relyea]

rob can use it. I wouldn't say it is critical.

Mostly, I misunderstood target email, and thought it was the list of things that were targetted for 3.11.7. After I realized the truth, I also realized that this would be a nice have.

It's not a high priority item.

bob

Comment 16

[Robert Relyea]

Comment on attachment 203033 [details] [diff] [review]
Complete the needed framework functions.

we don't really need this in 3.11.x. dropping review request.

Comment 17

[Nelson Bolyard (seldom reads bugmail)]

Agreed.

Comment 18

[Julien Pierre]

So, should this bug be resolved fixed then ?

Comment 19

[Robert Relyea]

yes.