953246 - gdk-screenshot.cpp:80:32: error: ‘nullptr’ was not declared in this scope

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Frank Wein [:mcsmurf]]

Linux SeaMonkey build with gcc 4.5 fails with this error:
../../../../../mozilla/testing/tools/screenshot/gdk-screenshot.cpp: In function ‘int main(int, char**)’:
../../../../../mozilla/testing/tools/screenshot/gdk-screenshot.cpp:80:32: error: ‘nullptr’ was not declared in this scope
../../../../../mozilla/testing/tools/screenshot/gdk-screenshot.cpp:130:27: error: ‘nullptr’ was not declared in this scope

Fallout from Bug 784739

Comment 1

[Frank Wein [:mcsmurf]]

Now, are mozilla-specific includes ok in this file? As gdk-screenshot.cpp looks to me like it should compile with system includes only. I wanted to insert "#include "mozilla/NullPtr.h"" in that file.

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch

In this specific case I think it's ok to revert to NULL. I'm mostly doing this because this file looks like it might be useful for other projects, too (note this file does not use the normal MPL license). Other projects might not want to use any Mozilla-specific headers. So I think in this case using NULL instead of nullptr/including our version of nullptr.h is ok.

Comment 3

[Frank Wein [:mcsmurf]]

Though " #if (MOZ_WIDGET_GTK == 2)" is certainly Mozilla-specific... I'll let you decide what solution to use :)

Comment 4

[Philip Chee]

(In reply to Frank Wein [:mcsmurf] from comment #3)
> Though " #if (MOZ_WIDGET_GTK == 2)" is certainly Mozilla-specific... I'll
> let you decide what solution to use :)

Compare: https://hg.mozilla.org/mozilla-central/rev/8a723f12da34

Comment 5

[Frank Wein [:mcsmurf]]

Yes, that's the other solution that's possible.

Comment 6

[(no longer active)]

Comment on attachment 8351553 [details] [diff] [review]
Patch

Review of attachment 8351553 [details] [diff] [review]:
-----------------------------------------------------------------

You should include NullPtr.h here.

Comment 7

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd5fd4487586

Comment 8

[Frank Wein [:mcsmurf]]

Ok, thanks ;)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd5fd4487586

Comment 10

[Frank Wein [:mcsmurf]]

Attachment: Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 784739
User impact if declined: Patch is only relevant for developers
Testing completed (on m-c, etc.): Works fine on m-c
Risk to taking this patch (and alternatives if risky): none, fixes a compile failure for older gcc compilers
String or IDL/UUID changes made by this patch: -

Comment 11

[(no longer active)]

This is NPOTB, so it doesn't require approval.

Comment 12

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/releases/mozilla-aurora/rev/71ad7ff30010