953316 - Beef up dumpObject output to include all object flags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: objectflags-dump.diff

Not sure why we don't have these...

Comment 1

[Brian Hackett [Laid off!]]

Comment on attachment 8351604 [details] [diff] [review]
objectflags-dump.diff

Review of attachment 8351604 [details] [diff] [review]:
-----------------------------------------------------------------

It's pretty easy for these to go out of phase.  Maybe add a mechanism to test for unrecognized flags in the dump functions and print some "unknown flag" message or something to make this more obvious?  Though just this is fine.

Comment 2

[Jeff Walden [:Waldo]]

I added a comment by the objectflags enums that people need to keep the list synced with JSObject::dump.  So long as the flags are handled one at a time in JSObject::dump, doesn't seem there's a better way to do it.  We could perhaps have Shape::dumpObjectFlags or something to at least move it into Shape's domain, but I didn't want to rathole too much here.  :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/d574815fe704

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d574815fe704

Comment 4

[Jason Orendorff [:jorendorff]]

Thank you.