953360 - ping should split on whitespace, not only space

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://mxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShell.cpp?rev=8939e7f497db#370 splits on U+20 only, rather than on HTML whitespace.

Comment 1

[Robert Longson [:longsonr]]

Attachment: like so?

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 8351652 [details] [diff] [review]
like so?

r=jst, but please do write tests for this as well! Thanks!

Comment 3

[Robert Longson [:longsonr]]

The original implementation seems to have come from bug 324642. That landed without tests.

Can you give me some hints as to how to write a test for this?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Not sure. Maybe bz has an idea? I'll think about it some more.

Comment 5

[Boris Zbarsky [:bzbarsky]]

You could write a mochitest with an sjs where the ping points to the sjs and then after you click the link and the link navigation finishes you query the sjs to see whether it got pinged...

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

The patch I landed in bug 786347 has tests [1].

[1] https://hg.mozilla.org/mozilla-central/rev/0099c1899f99

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0002-Bug-953360-a-ping-attribute-should-split-on-white-sp.patch

Rebased patch from Robert. Carrying over r=jst.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0003-Bug-953360-Test-that-a-ping-attribute-splits-on-whit.patch

Wrote a test to ensure the <a ping> attribute properly splits on white spaces.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2c91ff3ec49
https://hg.mozilla.org/integration/mozilla-inbound/rev/d49aee2034ae

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2c91ff3ec49
https://hg.mozilla.org/mozilla-central/rev/d49aee2034ae