Closed Bug 95337 Opened 18 years ago Closed 18 years ago

crop="right" and crop="left" should become start/end and honor 'direction'

Categories

(Core :: Layout: Text and Fonts, defect)

x86
Windows 2000
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: hyatt, Assigned: hyatt)

References

Details

Attachments

(1 file)

Cropping should automatically reverse itself when the direction goes to rtl.
Mine
Assignee: mkaply → hyatt
Blocks: 70753
Not that I have a clue about the rest of it, but ... this is a no-op?

+    if (vis->mDirection == NS_STYLE_DIRECTION_RTL)
+      (mCropStyle == 2) ? 0 : 2;

[s]r=ben@netscape.com with the "mCropStyle =" bit we discussed on IRC.
Yes, nice catch jrgm.  I was supposed to assign into mCropStyle.
Status: NEW → ASSIGNED
Why not save a branch, do 'mCropStyle = 2 - mCropStyle;' -- you've already
tested that mCropStyle is 0 or 2.

How about an NS_ASSERTION(frame, "disastrous!"); here?

+    if (!frame)
+      return; // This is disastrous.

Now I'm just picking nits.  r=brendan@mozilla.org

/be
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
There was a typo in the code that was checked in:

+ mCropStyle = mCropStyle - 2; // Right becomes left, left becomes right.   

if mCropStyle was 0 mCropStyle becomes -2, should be "2 - mCropStyle".

Reopening so that it won't be forgotten.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Wahhh, hyatt didn't do what I said!

/be
forgive hyatt for messing up at 2 in the morning please. thanks. :)
fixed.
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: giladehven → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.