953438 - Change nsIFrame::HasTerminalNewline to HasSignificantTerminalNewline

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 8351734 [details] [diff] [review]
fix

Review of attachment 8351734 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsFrame.cpp
@@ +6355,5 @@
>                                                            endOfLine, 0);
>        FrameContentRange range = GetRangeForFrame(targetFrame.frame);
>        aPos->mResultContent = range.content;
>        aPos->mContentOffset = endOfLine ? range.end : range.start;
> +      if (endOfLine && targetFrame.frame->HasSignificantTerminalNewline()) {

At this callsite, there wasn't originally a check for StyleText()->NewlineIsSignificant(), so this changes the logic here. Are there examples where this will lead to an actual change in behavior?

Comment 3

[alexander :surkov (:asurkov)]

yes, bug 947170

Comment 4

[Jonathan Kew [:jfkthame]]

Ah, thanks - that provides the missing context here.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdbbbb3a99b4

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdbbbb3a99b4