Closed Bug 953438 Opened 6 years ago Closed 6 years ago

Change nsIFrame::HasTerminalNewline to HasSignificantTerminalNewline

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file)

No description provided.
Attached patch fixSplinter Review
Attachment #8351734 - Flags: review?(jfkthame)
Comment on attachment 8351734 [details] [diff] [review]
fix

Review of attachment 8351734 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsFrame.cpp
@@ +6355,5 @@
>                                                            endOfLine, 0);
>        FrameContentRange range = GetRangeForFrame(targetFrame.frame);
>        aPos->mResultContent = range.content;
>        aPos->mContentOffset = endOfLine ? range.end : range.start;
> +      if (endOfLine && targetFrame.frame->HasSignificantTerminalNewline()) {

At this callsite, there wasn't originally a check for StyleText()->NewlineIsSignificant(), so this changes the logic here. Are there examples where this will lead to an actual change in behavior?
Ah, thanks - that provides the missing context here.
Blocks: 947170
Attachment #8351734 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/cdbbbb3a99b4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.