953528 - Double-click on Disconnect opens acount properties

Status: RESOLVED FIXED

(Instantbird Graveyard :: Account manager, defect)

Description

[Instantbot]

*** Original post on bio 77 by Julien Ramakichenin <julien AT instantbird.org> at 2008-07-26 12:14:00 UTC ***

Double-click on the "Disconnect" button in the account manager shouldn't open the account properties window.

Comment 1

[Romain BEZUT]

Attachment: patch

*** Original post on bio 77 as attmnt 42 at 2008-08-10 02:14:00 UTC ***

patch, but there must be something to prevent user from double clicking on connect / disconnect (disable button for about 500ms).
New report will be open

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8351786 [details] [diff] [review]
patch

*** Original change on bio 77 attmnt 42 at 2008-08-10 05:53:06 UTC ***

My first comment was "Perfect, thanks!" but then I saw a typo...

>Index: instantbird/base/content/instantbird/account.xml

>+          // Prevent from loading an account wizzard

wizard, not wizzard.
I think I would have used "opening" rather than loading in this comment, but it doesn't matter.

r=me, don't bother to upgrade the patch, I can take care of the typo while landing.

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 77 at 2008-08-13 21:37:48 UTC ***

Sending        instantbird/base/content/instantbird/account.xml
Transmitting file data .
Committed revision 268.

Fixed. The commit message log contains only "Bug 953528 (bio 77)", I hit return by mistake before typing the full message, I'm sorry about this :-(.