953675 - Don't treat accounts immeadiately as connected

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Benedikt Pfeifer]

*** Original post on bio 229 at 2009-08-29 10:25:00 UTC ***

Right now the facebook protocol plugin keeps reconnecting all the time, with the timer starting anew from one second. It's looks like it's connected for a short moment, so I guess we (or is it libpurple?) are taking it as properly connected and reset the reconnect timer.
Someone (Eventreur?) proposed to wait for e.g. ten seconds before treating an account as properly connected.

Comment 1

[Romain BEZUT]

Attachment: Patch V1

*** Original post on bio 229 as attmnt 230 at 2009-08-30 19:05:00 UTC ***

Add a member in purpleIAccount to keep the last time the account was successfully connected.
Used to check if a disconnect with error occurred within the 10 seconds after this timestamp.

I have also exposed this timestamp, it can be a useful information for Javascript.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8351974 [details] [diff] [review]
Patch V1

*** Original change on bio 229 attmnt 230 at 2009-08-30 20:28:32 UTC ***

>diff --git a/purple/purplexpcom/public/purpleIAccount.idl b/purple/purplexpcom/public/purpleIAccount.idl

>+  /* Time stamp of the last connection */
>+  readonly attribute PRInt64 timeOfLastConnect;

The comment here should at least state that the value is unreliable when the account is not connected.

>diff --git a/purple/purplexpcom/src/purpleAccount.cpp b/purple/purplexpcom/src/purpleAccount.cpp

>@@ -1095,16 +1097,23 @@ void purpleAccount::SetDisconnectReason(

>+  // If the last successful connection is older than 10 seconds, reset the
>+  // number of reconnection attemps.
>+  if (mTimeOfLastConnect && mTimeOfLastConnect + 10 * PR_USEC_PER_SEC < PR_Now()) {
>+    mReconnectAttempts = 0;
>+    mTimeOfLastConnect = 0;
>+  }

The value 10 here should be an explicitly named constant with a #define at the beginning of this file.

Looks good otherwise!

Comment 3

[Romain BEZUT]

Attachment: Patch V2

*** Original post on bio 229 as attmnt 231 at 2009-08-30 20:53:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[Romain BEZUT]

Comment on attachment 8351974 [details] [diff] [review]
Patch V1

*** Original change on bio 229 attmnt 230 at 2009-08-30 20:53:19 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8351975 [details] [diff] [review]
Patch V2

*** Original change on bio 229 attmnt 231 at 2009-08-31 01:27:30 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Florian Quèze [:florian]]

*** Original post on bio 229 at 2009-08-31 01:31:22 UTC ***

https://hg.instantbird.org/instantbird/rev/04b066f0073c