Closed Bug 953766 Opened 10 years ago Closed 10 years ago

F2 key causes problem during aliasing

Categories

(Instantbird Graveyard :: Contacts window, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Unassigned)

Details

Attachments

(1 file)

*** Original post on bio 323 at 2010-01-28 12:34:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
*** Original post on bio 323 as attmnt 262 at 2010-01-28 12:34:00 UTC ***

When pressing F2 while already aliasing a buddy, the edit mode is cancelled and can't be entered (neither by key, nor by context menu) again until the buddy is deselected and selected again.

Checking if we're already aliasing a buddy and returning early fixes the problem.
Attachment #8352005 - Flags: review?(florian)
Comment on attachment 8352005 [details] [diff] [review]
Patch: check if already aliasing

*** Original change on bio 323 attmnt 262 at 2010-01-28 12:36:31 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352005 - Attachment is patch: true
Attachment #8352005 - Attachment mime type: application/octet-stream → text/plain
*** Original post on bio 323 at 2010-01-29 22:59:27 UTC ***

Thanks for noticing this!

Fixed: https://hg.instantbird.org/instantbird/rev/6361822acbff

I kept your test for safety, but I also added 2 tests in the "keyPress" method for consistency (that's where the other tests regarding which command is valid are).
Status: NEW → RESOLVED
Closed: 10 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 0.2b2
Comment on attachment 8352005 [details] [diff] [review]
Patch: check if already aliasing

*** Original change on bio 323 attmnt 262 at 2010-01-29 23:00:09 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8352005 - Flags: review?(florian)
You need to log in before you can comment on or make changes to this bug.