953941 - Use CSS3

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, enhancement)

Description

[Benedikt Pfeifer]

*** Original post on bio 504 at 2010-09-14 11:09:00 UTC ***

Take advantage of the opportunities that Css3 offers, like transitions.

* The own animation code for sign-on and off on the buddy list could be replaced by transitions.

* Addition: a short transition could be added for status changes of buddies, for example fading the icon in (still quickly) instead of just popping up the new icon.

Comment 1

[Florian Quèze [:florian]]

*** Original post on bio 504 at 2010-09-14 11:50:16 UTC ***

Also:
* Replace -moz-box-shadow with box-shadow
* Replace the JS animations in message themes (status messages fades in and out on hover on Dark I think, and bubbles fades in when inserted on the Bubbles theme).

Comment 2

[Florian Quèze [:florian]]

Attachment: Use CSS transition for buddy list animations

*** Original post on bio 504 as attmnt 395 at 2010-11-07 23:57:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Benedikt Pfeifer]

Comment on attachment 8352138 [details] [diff] [review]
Use CSS transition for buddy list animations

*** Original change on bio 504 attmnt 395 at 2010-11-08 00:42:34 UTC ***

To match the comment and the logical order more closely it would be better to have the stylesheets in a different order and the target value of the collapsing animation included with the definition of the transition. Something like this then:

> buddy:not([state]){
>   height: 0;
> }
>
> buddy[state="showing"] {
>   -moz-transition: > height .4s ease-in;
}
>
> buddy[state="collapsing"],
> group[collapsing="true"] {
>   height: 0;
>   -moz-transition: height .2s ease-in;
> }

The idea with moving the critical parts away from the theme into the required css-file is also very reasonable.

Looks good, granting review+ ;)

Comment 4

[Florian Quèze [:florian]]

*** Original post on bio 504 at 2010-11-08 01:10:59 UTC ***

(In reply to comment #0)
> Take advantage of the opportunities that Css3 offers, like transitions.
> 
> * The own animation code for sign-on and off on the buddy list could be
> replaced by transitions.

This part is fixed: https://hg.instantbird.org/instantbird/rev/e50e70653d48

(In reply to comment #3)

> Looks good, granting review+ ;)

Thanks for the quick review! I made the suggested changes before the check-in.

Comment 5

[Florian Quèze [:florian]]

*** Original post on bio 504 at 2011-05-30 17:58:10 UTC ***

Handled the box-shadow, border-radius and background-origin replacements in https://hg.instantbird.org/instantbird/rev/3a3d0e64df1b

I think replacing JS animations inside message themes is a bit out of the scope here, so I'll resolve the bug as fixed.

Comment 6

[Florian Quèze [:florian]]

*** Original post on bio 504 at 2011-08-27 00:34:43 UTC ***

(In reply to comment #1)

> * Replace the JS animations in message themes (status messages fades in and out
> on hover on Dark I think, and bubbles fades in when inserted on the Bubbles
> theme).

The animation of the Bubbles theme is being removed in bug 954429 (bio 995). Dark still has some JS-animation code.

Comment 7

[Florian Quèze [:florian]]

*** Original post on bio 504 at 2012-02-09 17:02:29 UTC ***

(In reply to comment #6)
> Dark still has some JS-animation code.

Mic has filed this as bug 954690 (bio 1259).