954032 - Icons in menus on Linux

Status: RESOLVED WONTFIX

(Instantbird Graveyard :: Other, defect)

Description

[Instantbot]

*** Original post on bio 595 by Azat Tymerkaev <tymerkaev AT gmail.com> at 2010-11-21 14:52:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 1

[Benedikt Pfeifer]

Attachment: Patch adding necessary IDs to context menu items, by tymerkaev

*** Original post on bio 595 as attmnt 467 at 2011-01-04 17:25:00 UTC ***

This patch is adding the IDs that are necessary to reference the menu items from CSS. It was created by tymerkaev, I'm only adding it because it was in my email inbox and here it is accessible to all.

Comment 2

[Benedikt Pfeifer]

*** Original post on bio 595 at 2011-01-04 17:30:27 UTC ***

>+   <menuitem id="context_newAccount"
>+             command="cmd_new"/>
I'd call the id "context_new", so all items have the same pattern of context_<item specific> and cmd_<item specific> IDs and command names.

>+   <menuitem id="context_delete"
>+             command="cmd_delete"
Would look like here then.

>+   <menuitem id="context_properties"
>+             command="cmd_edit"
Same issue.

Comment 3

[Benedikt Pfeifer]

*** Original post on bio 595 at 2012-04-18 16:46:47 UTC ***

The icons would be defined using a "moz-icon://" url, like here, I think.

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/gnomestripe/global/button.css

Comment 4

[Benedikt Pfeifer]

*** Original post on bio 595 at 2012-04-18 16:58:51 UTC ***

More information:

https://developer.mozilla.org/en/URIScheme
http://mxr.mozilla.org/mozilla-central/source/image/decoders/icon/nsIIconURI.idl
http://mxr.mozilla.org/mozilla-central/source/image/decoders/icon/nsIconURI.cpp
http://forums.mozillazine.org/viewtopic.php?f=40&t=809895
http://developer.gnome.org/gtk/2.24/gtk-Stock-Items.html ??

Comment 5

[Benedikt Pfeifer]

*** Original post on bio 595 at 2012-04-30 15:11:16 UTC ***

Does anyone know if the platform (or whatelse) handles the case that the user disabled icons in menus? (check with Firefox if possible/visible somewhere?)
If that's the case, we could add the icons with no drawback for people who don't like them.

CC'ing aleth as our Linux person ;)

Comment 6

[aleth [:aleth]]

*** Original post on bio 595 at 2012-04-30 17:09:46 UTC ***

They are turned on/off via gnome config settings I think. Firefox certainly has icons in the menus, though I haven't tested whether FF respects the config setting.

Comment 7

[Florian Quèze [:florian]]

*** Original post on bio 595 at 2012-04-30 21:55:18 UTC ***

(In reply to comment #6)
> They are turned on/off via gnome config settings I think. Firefox certainly has
> icons in the menus, though I haven't tested whether FF respects the config
> setting.

IIRC it does respect the system setting, although I haven't been able to find again the CSS rule doing that :-/ (I think when I first saw it, it was using DOM inspector on a menuitem on my Ubuntu machine where the theme disables the menu icons by default).

Comment 8

[Benedikt Pfeifer]

*** Original post on bio 595 at 2012-05-09 10:27:10 UTC ***

flo found the CSS rule again at http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/xul.css#368:


367 %ifdef MOZ_WIDGET_GTK2
368 /********* detection of system setting to use icons in menus ***********/
369 @media not all and (-moz-images-in-menus) {
370   .menu-iconic-left {
371     visibility: hidden;
372   }
373   :-moz-any(menuitem[type], .menuitem-with-favicon) > .menu-iconic-left {
374     visibility: visible;
375   }
376 }
377 %endif

Comment 9

[Instantbot]

There was missing email mapping information for this bug during the BIO to BMO merge, manually assigning this bug.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.