954185 - libpurple commands not working

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 751 at 2011-04-12 12:14:00 UTC ***

At some point recently most commands stopped working (it seems any protocol specific command, as far as I can tell).

Some commands, such as /me still seem to work, however.  Also, any command I've registered for my JS-IRC still works, but /join, etc. are not working with the libpurple IRC.

Possibly this was a as a result of the core changes that happened recently?  Bugs of interested may be bug 953569 (bio 118) as well as the parts of the core that have recently been rewritten.  Tonight I'll try to find a more specific regression range besides just "recently".

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 751 at 2011-04-12 12:14:54 UTC ***

Setting to blocking 0.3 since this is a pretty major regression.

Comment 2

[Patrick Cloke [:clokep]]

*** Original post on bio 751 at 2011-04-12 13:36:31 UTC ***

(In reply to comment #0)
> Some commands, such as /me still seem to work, however.
This is wrong. No commands seem to be working. (Just verified this with flo on Instantbird and me on Mibbit.)

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch

*** Original post on bio 751 as attmnt 583 at 2011-04-12 13:46:00 UTC ***

Just give the actual purpleConversation to the command instead of the imConversation wrapper.

Comment 4

[Florian Quèze [:florian]]

*** Original post on bio 751 at 2011-04-12 13:48:02 UTC ***

Just for reference, the imConversation wrapper doesn't work when trying to use libpurple commands because this code is looking for an instance of purpleConvIM or purpleConvChat, not just its XPCOM interface: http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleInitCommands.cpp#115

Comment 5

[Florian Quèze [:florian]]

*** Original post on bio 751 at 2011-04-12 22:21:04 UTC ***

(In reply to comment #0)

> Possibly this was a as a result of the core changes that happened recently? 
> Bugs of interested may be bug 953569 (bio 118) as well as the parts of the core that have
> recently been rewritten.  Tonight I'll try to find a more specific regression
> range besides just "recently".

It's a regression from https://hg.instantbird.org/instantbird/rev/c119343f2f9f (bug 954133 (bio 698)).

Comment 6

[Florian Quèze [:florian]]

*** Original post on bio 751 at 2011-04-12 22:23:20 UTC ***

Pushed attachment 8352325 [details] [diff] [review] (bio-attmnt 583) as https://hg.instantbird.org/instantbird/rev/40334b5c913e