95426 - Remove $onebug cruft.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Matthew Tuck [:CodeMachine]]

There's code in editkeywords.cgi and queryhelp.cgi that works around an old bug
in MySQL:

    SendSQL("SELECT keyworddefs.id, keyworddefs.name, keyworddefs.description,
                    COUNT(keywords.bug_id), keywords.bug_id
             FROM keyworddefs LEFT JOIN keywords ON keyworddefs.id =
                  keywords.keywordid
             GROUP BY keyworddefs.id
             ORDER BY keyworddefs.name");
    while (MoreSQLData()) {
        my ($id, $name, $description, $bugs, $onebug) = FetchSQLData();
	...
        if (!$onebug) {
            # This is silly hackery for old versions of MySQL that seem to
            # return a count() of 1 even if there are no matching.  So, we 
            # ask for an actual bug number.  If it can't find any bugs that
            # match the keyword, then we set the count to be zero, ignoring
            # what it had responded.
	...

I dont' think having workarounds for this is a good idea in the first place
because it's liable to occur in other places and people won't remember to do the
workaround.

So let's kill the code and update the MySQL version requirement.  This bug does
not occur on landfill (v3.22.30) and I'm told mothra runs v3.22.32.

The main problem is we're not sure what version it was fixed in.  I can see
various references to COUNT, but I suspect this is the fix:

3.21.22: FIX COUNT(*) problems when the WHERE clause didn't match any records.
(Bug from 3.21.17.)

If this is the case, our current version check (which I'm told is 3.22.5) should
already cover it.  But if we can't verify the fixed version, we could change the
requirement to v3.22.30.

Comment 1

[Dave Miller [:justdave]]

Yep, our current version check would catch this.  Let's remove the hack.

Comment 2

[Matthew Tuck [:CodeMachine]]

Moving to new Bugzilla product ...

Comment 3

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 4

[Gervase Markham [:gerv]]

-> me.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Remove the cruft.

Gerv

Comment 6

[Gervase Markham [:gerv]]

Checked in.

Checking in editkeywords.cgi;
/cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v  <--  editkeywords.cgi
new revision: 1.11; previous revision: 1.10
done
Checking in queryhelp.cgi;
/cvsroot/mozilla/webtools/bugzilla/queryhelp.cgi,v  <--  queryhelp.cgi
new revision: 1.14; previous revision: 1.13
done

Gerv