954307 - Misnamed variant of the Bubble theme

Status: RESOLVED WONTFIX

(Instantbird Graveyard :: Preferences, defect)

Description

[Instantbot]

*** Original post on bio 874 by Masaki <silnce AT me.com> at 2011-06-29 20:01:00 UTC ***

Hey there,

Preferences option, Themes -> Bubbles -> Variant "Grey Pink" is listed as "Grey - Ping".

Comment 1

[Benedikt Pfeifer]

*** Original post on bio 874 at 2011-06-29 20:30:40 UTC ***

I can confirm that we have a typo in a variant name ;)

Thank you for reporting this, Masaki!

Comment 2

[Patrick Cloke [:clokep]]

*** Original post on bio 874 at 2011-09-16 14:25:32 UTC ***

Seems the error is on http://lxr.instantbird.org/instantbird/source/instantbird/themes/jar.mn#384 and is a 1 character fix.

Comment 3

[Benedikt Pfeifer]

Attachment: Fix: Rename target in jar.mn

*** Original post on bio 874 as attmnt 1360 at 2012-04-15 08:44:00 UTC ***

I haven't found any other reference to the wrong name either, so I think this is all that's needed. I can't build and can't test this therefore.

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8353113 [details] [diff] [review]
Fix: Rename target in jar.mn

*** Original change on bio 874 attmnt 1360 at 2012-04-15 12:53:27 UTC ***

(In reply to comment #3)
> Created attachment 8353113 [details] [diff] [review] (bio-attmnt 1360) [details]
> Fix: Rename target in jar.mn
> 
> I haven't found any other reference to the wrong name either, so I think this
> is all that's needed. I can't build and can't test this therefore.

So this fix seems fine, I believe the reason we never actually fixed this is because we were unsure what would happen if someone was using the "Grey - Ping" theme. (I.e. is there a migration path?)

Comment 5

[Benedikt Pfeifer]

Mass-removing myself from being assignee of any Chat related bug as I'm no longer active.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

On the behalf of Florian:
Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.