954324 - Add-ons window doesn't close on Cmd+W

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[Instantbot]

*** Original post on bio 891 by gies.nate AT gmail.com at 2011-07-02 23:07:00 UTC ***

Add-Ons window will not close when active and CMD (Apple) + W is pressed, unlike the other windows in the app.

Comment 1

[Florian Quèze [:florian]]

*** Original post on bio 891 at 2011-07-02 23:14:45 UTC ***

Right. Thanks for reporting the issue!

I wonder if we should make the Escape key close the window too (like we have done for the account manager).

Comment 2

[shrihari]

Attachment: Closes the Add-ons Window on Cmd+D

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8384569 [details] [diff] [review]
Closes the Add-ons Window on Cmd+D

Review of attachment 8384569 [details] [diff] [review]:
-----------------------------------------------------------------

This patch works well, but I have some trivial comments.

># HG changeset patch
># Parent 2d6797f5e844ce17944f368bcbd45adf62f13c9b
># User Shrihari Sankaran <[e-mail]>
>Fixed: Add-ons Window doesn't close on Cmd+D

I think you wanted "Cmd+W" here. Also please format this as "Bug xxxxx - bug description, r=blabla."

::: im/content/extensions.xul
@@ +23,5 @@
>  #ifdef XP_MACOSX
>  #include menus.xul.inc
>  #endif
>  
> +  <commandset id="logsCommands">

I think you want to name this a bit better? ;)

@@ +27,5 @@
> +  <commandset id="logsCommands">
> +    <command id="cmd_close" oncommand="window.close();"/>
> +  </commandset>
> +
> +  <keyset id="logsKeys">

Here too.

@@ +31,5 @@
> +  <keyset id="logsKeys">
> +    <key id="key_close" key="w" modifiers="accel" command="cmd_close"/>
> +    <key id="key_close2" keycode="VK_ESCAPE" command="cmd_close"/>
> +  </keyset>
> +  

Nit: Remove this whitespace.

Comment 4

[shrihari]

Attachment: Add-ons Windows closes on Cmd+W

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8384587 [details] [diff] [review]
Add-ons Windows closes on Cmd+W

r=me, but please remove the colon from my name in the commit message. :)

Thanks for the patch!

Comment 6

[shrihari]

Attachment: Add-ons Windows closes on Cmd+W

Comment 7

[shrihari]

r+ carried forward as per comment 5 by nhnt11.

Comment 8

[Florian Quèze [:florian]]

Note: while nhnt11 isn't officially an Instantbird peer (yet!), it's fine that he's the reviewer in this case, as aleth asked him to take other the review from him. Anyway, if you need another additional flag to feel comfortable, rs=me.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/269709e19df2