954350 - Problems when connecting to irc.umich.edu (requires ident or non-standard captcha)

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[Benedikt Pfeifer]

*** Original post on bio 917 at 2011-07-11 11:44:00 UTC ***

The server's asking to respong with a PONG <string> where the string is unfortunately not displayed anywhere. Exact message:

"(notice) To complete your connection to this server, type "/QUOTE PONG :cookie", where cookie is the following ascii."

No following ascii is displayed (or even received?) though.

I see the following messages on the error console during connecting (the account is stuck with status "connecting..."):


Warning: Unrecognized string: NOTICE AUTH :*** Processing connection to irc.umich.edu

Source File: http://hg.instantbird.org/instantbird/raw-file/c7423504633e/purple/libpurple/protocols/irc/parse.c
Line: 750
Source Code:
irc: irc_parse_error_cb

Warning: Unrecognized string: NOTICE AUTH :*** Looking up your hostname...

Source File: http://hg.instantbird.org/instantbird/raw-file/c7423504633e/purple/libpurple/protocols/irc/parse.c
Line: 750
Source Code:
irc: irc_parse_error_cb

Warning: Unrecognized string: NOTICE AUTH :*** Checking Ident

Source File: http://hg.instantbird.org/instantbird/raw-file/c7423504633e/purple/libpurple/protocols/irc/parse.c
Line: 750
Source Code:
irc: irc_parse_error_cb

Warning: Unrecognized string: NOTICE AUTH :*** Found your hostname

Source File: http://hg.instantbird.org/instantbird/raw-file/c7423504633e/purple/libpurple/protocols/irc/parse.c
Line: 750
Source Code:
irc: irc_parse_error_cb

Warning: Unrecognized string: NOTICE AUTH :*** No Ident response

Source File: http://hg.instantbird.org/instantbird/raw-file/c7423504633e/purple/libpurple/protocols/irc/parse.c
Line: 750
Source Code:
irc: irc_parse_error_cb



CC'ing the original reporter of the bug.

Comment 1

[Benedikt Pfeifer]

*** Original post on bio 917 at 2011-07-11 11:47:52 UTC ***

OS + Instantbird version of the original reporter is "Windows 7 64bit - version 1.0 (20110623121653)".

I'm seeing it on Windows 7, Instantbird version 1.1a1pre (20110709041719).

Comment 2

[Benedikt Pfeifer]

*** Original post on bio 917 at 2011-07-11 11:52:11 UTC ***

Patrick, do you see this problem with js-irc as well? Thanks in advance!

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 917 at 2011-07-11 12:26:22 UTC ***

(In reply to comment #2)
> Patrick, do you see this problem with js-irc as well? Thanks in advance!

So I can't seem to grab a connection to it currently, but I was able to find the server information: http://www.efnet.org/?module=servers&server_id=15

The important part being:
-   * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
-   * For users who do not have ident installed, they will be required      *
-   * to type in /quote cookie :@@@@@@ where @ is a letter. These letters   *
-   * are displayed on the screen when connecting to the server. To get     *
-   * around this, install identd.                                          *
-   * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

I'll need to get a raw connection to the server to see what's being sent. I'll check later. All the warnings are unrelated and are just libpurple sucking at handling messages. (They're the standard steps of an the auth request, they pop up for servers that connect too.) Anyway, I'll check it out. :)

Comment 4

[Patrick Cloke [:clokep]]

*** Original post on bio 917 at 2011-07-13 13:51:31 UTC ***

So I was able to telnet into the server and it displays a message as ASCII art with a response numeric somewhere in the 900s (I think it was 991, but I'm unsure). I can't find a reference to it anywhere. Anyway though, I think libpurple eats numerics it doesn't understand (hence why it's not being shown to you), it's possible we could write a simple handler for this and include it, but it would definitely be a bit of a hack.  (Also, I think I got banned from the server...so it'd be hard for me to debug it.)

The "real" solution is to include identd, which the libpurple devs have no interest in (last I heard), it's on my list of things to include once IRC is rewritten though.

Comment 5

[Patrick Cloke [:clokep]]

Attachment: telnet session

Well, we're no longer using libpurple, so this is fixable. A full telnet session is attached.

Displaying this is pretty easy, so I'll go ahead and do that. Displaying the NOTICE that tells what to do might be a bit harder though.

Comment 6

[Patrick Cloke [:clokep]]

Attachment: Patch v1

This was sufficiently annoying, but I did find a stupid bug in our ZNC send password capability. It would not work properly if you set your nick to AUTH.

Note that you'll want to use a fixed width font when using this patch (unless there's a way we can do that sanely?)

Comment 7

[aleth [:aleth]]

Comment on attachment 8474117 [details] [diff] [review]
Patch v1

Review of attachment 8474117 [details] [diff] [review]:
-----------------------------------------------------------------

There are crazy things out there in IRC land. r+ with nits fixed.

::: chat/protocols/irc/ircNonStandard.jsm
@@ +31,5 @@
> +      // Try to avoid the stupid case where the user's nick is AUTH. If this
> +      // happens, it is ambiguous if it is an AUTH message or a NOTICE to the
> +      // user. It is recommended you test for something else to have more
> +      // confidence.
> +      let isAuth = aMessage.params[0] == "AUTH" && !this._nickname == "AUTH";

Who sets their nick to AUTH? ;)

@@ +35,5 @@
> +      let isAuth = aMessage.params[0] == "AUTH" && !this._nickname == "AUTH";
> +
> +      // Some servers , e.g. irc.umich.edu, use NOTICE before connection to give
> +      // directions to users.
> +      if (!this.connected && !isAuth && !aMessage.params[1].startsWith("***")) {

Is the last check due to ZNC? If so, use a local boolean. If not, explain in the comment ;)

@@ +156,5 @@
> +    },
> +
> +    "998": function(aMessage) {
> +      // irc.umich.edu shows an ASCII captcha that must be typed in by the user.
> +      // TODO Is there a way to make this preformatted text to ignore fonts?

You mean "to use a monospace font" which is that unreliable |...| feature I guess.

Comment 8

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #7)
> You mean "to use a monospace font" which is that unreliable |...| feature I
> guess.

The only other way to do it would be to use a new message type instead of "incoming" that is then CSS styled to use monospaced font.

Comment 9

[Patrick Cloke [:clokep]]

Attachment: Patch v2

Comment 10

[aleth [:aleth]]

Comment on attachment 8475544 [details] [diff] [review]
Patch v2

Review of attachment 8475544 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I wonder if we have any UMich users...

Comment 11

[aleth [:aleth]]

Here's how you can do the monospace stuff:

1) add the "noFormat" flag as well as "incoming" to the messages: http://mxr.mozilla.org/comm-central/source/chat/components/public/prplIMessage.idl#65

2) Add some CSS to conv.css that sets font-family: monospace for messages with the noFormat flag. Probably you need to add noFormat to the messageClasses in imThemes too.

Comment 12

[Patrick Cloke [:clokep]]

Attachment: Patch v3

This implements the monospaced font...

Comment 13

[Patrick Cloke [:clokep]]

Comment on attachment 8479539 [details] [diff] [review]
Patch v3

Review of attachment 8479539 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/themes/conv.css
@@ +45,5 @@
>  .ib-nick[left] {
>    color: grey;
>  }
> +
> +.monospaced {

It seems like other formatting in specific to each theme, should this be as well?

@@ +49,5 @@
> +.monospaced {
> +  font-family: monospace;
> +}
> +/* Ensure that monospaced lines are formatted without line breaks. */
> +.monospaced > .ib-msg-txt {

This actually forces things OUTSIDE of the bubbles if you make the width too small.

Comment 14

[Florian Quèze [:florian]]

(In reply to Patrick Cloke [:clokep] from comment #13)

> @@ +49,5 @@
> > +.monospaced {
> > +  font-family: monospace;
> > +}
> > +/* Ensure that monospaced lines are formatted without line breaks. */
> > +.monospaced > .ib-msg-txt {
> 
> This actually forces things OUTSIDE of the bubbles if you make the width too
> small.

So it will cause an horizontal scrollbar to appear?

Comment 15

[Patrick Cloke [:clokep]]

(In reply to Florian Quèze [:florian] [:flo] from comment #14)
> (In reply to Patrick Cloke [:clokep] from comment #13)
> 
> > @@ +49,5 @@
> > > +.monospaced {
> > > +  font-family: monospace;
> > > +}
> > > +/* Ensure that monospaced lines are formatted without line breaks. */
> > > +.monospaced > .ib-msg-txt {
> > 
> > This actually forces things OUTSIDE of the bubbles if you make the width too
> > small.
> 
> So it will cause an horizontal scrollbar to appear?

No, it just clips over the bubble edge. You have to resize to see it still. (The message that we receive that uses this isn't actually THAT wide, it had plenty of room in my window, which I keep fairly small.)

Comment 16

[aleth [:aleth]]

Comment on attachment 8479539 [details] [diff] [review]
Patch v3

Review of attachment 8479539 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/themes/conv.css
@@ +46,5 @@
>    color: grey;
>  }
> +
> +.monospaced {
> +  font-family: monospace;

Themes can override or extend this if they like, this is the right place for the default.

@@ +50,5 @@
> +  font-family: monospace;
> +}
> +/* Ensure that monospaced lines are formatted without line breaks. */
> +.monospaced > .ib-msg-txt {
> +  white-space: pre;

Iirc we use pre-wrap for ib-msg-txt by default. That should also work, but of course it will mess up the ASCII art if bubbles are too small... so it seems this is a tradeoff you consciously chose.

Comment 17

[aleth [:aleth]]

Comment on attachment 8479539 [details] [diff] [review]
Patch v3

Review of attachment 8479539 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/themes/conv.css
@@ +49,5 @@
> +.monospaced {
> +  font-family: monospace;
> +}
> +/* Ensure that monospaced lines are formatted without line breaks. */
> +.monospaced > .ib-msg-txt {

Please double-check before checking this in that .ib-msg-txt is indeed always (for all message styles) a direct child of the element that gets the .monospaced class.

Comment 18

[Patrick Cloke [:clokep]]

Attachment: Patch v4 (without the extra pre)

Comment 19

[Patrick Cloke [:clokep]]

Attachment: Screenshot of Patch v3

Comment 20

[Patrick Cloke [:clokep]]

Attachment: Screenshot of Patch v4

Comment 21

[aleth [:aleth]]

Comment on attachment 8479900 [details] [diff] [review]
Patch v4 (without the extra pre)

Review of attachment 8479900 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 22

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/2505dd518163