954403 - Remove leftover socket listener/timers associated with an account when the account is disconnected

Status: RESOLVED FIXED

(Chat Core :: General, enhancement)

Description

[Florian Quèze [:florian]]

*** Original post on bio 969 at 2011-08-10 16:54:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

*** Original post on bio 969 as attmnt 775 at 2011-08-10 16:54:00 UTC ***

The attached patch tags all socket listener and timers with the account that created them, and when an account is marked disconnected, it double checks that no callback has been left behind.

I hope is that this hack would make a significant portion of our libpurple crashers disappear, as lots of them are from touching uninitialized memory in callbacks.
Unfortunately, I've no way to confirm this, as none of these crashers can easily be reproduced.

Will anybody dare to review this? ;)

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 969 at 2011-08-10 20:40:40 UTC ***

I've pushed this to try it on nightlies: https://hg.instantbird.org/instantbird/rev/35ea32c79962

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8352517 [details] [diff] [review]
Patch

*** Original change on bio 969 attmnt 775 at 2011-08-29 23:43:20 UTC ***

Clearing the review request. I don't think anybody will review this at this point.
Back when I attached it, Mook said on IRC that it didn't look *too* scary.

It seems to have had a good effect on our nightlies. The OSCAR top crasher seems to have disappeared, so I guess we will keep this at least for a release.