954607 - Add-ons need a notification when a conversation is detached and moved to a new window

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[Benedikt Pfeifer]

*** Original post on bio 1175 at 2011-11-18 10:01:00 UTC ***

Some extensions that attach themselves to a conversation (seen with restartless add-ons that can't use overlays) fail to notice when a conversation is moved to a new window and can't attach themselves again to the new conversation.

Or maybe there's a notification that I'm only not aware of?

Comment 1

[Florian Quèze [:florian]]

*** Original post on bio 1175 at 2012-03-02 14:50:14 UTC ***

Rephrasing the summary as I had to read the full description to have an idea of what this bug is about...

Comment 3

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1175 as attmnt 2461 at 2013-05-27 12:53:00 UTC ***

We currently fake a conversation-loaded notification after importing an existing conversation, instead we should just send it. This also requires no modifications to existing add-ons. I can't see any drawbacks.

Comment 4

[Benedikt Pfeifer]

Comment on attachment 8354228 [details] [diff] [review]
Patch

*** Original change on bio 1175 attmnt 2461 at 2013-05-27 19:32:41 UTC ***

Looks good and works fine! I tried with the add-on "Input Placeholder" and it works for detached tabs now as it works for any others.

Thanks a lot! This was a very annoying bug for me (and most likely others writing restartless add-ons for Instantbird too).

Comment 5

[aleth [:aleth]]

*** Original post on bio 1175 at 2013-05-29 09:13:50 UTC ***

I should mention that I've thought of one drawback: add-ons which add things to the actual browser content now have to check (on receiving conversation-loaded) that they don't add it twice.

Comment 6

[aleth [:aleth]]

Comment on attachment 8354228 [details] [diff] [review]
Patch

*** Original change on bio 1175 attmnt 2461 at 2013-05-29 11:17:55 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8354228 [details] [diff] [review]
Patch

*** Original change on bio 1175 attmnt 2461 at 2013-05-30 22:27:40 UTC ***

I don't feel confident reviewing this, and I don't want to block it for too long, so I think we should just try it on nightlies for a few days to see if it causes more issues than it fixes.

Comment 8

[Benedikt Pfeifer]

*** Original post on bio 1175 at 2013-05-30 22:36:00 UTC ***

(In reply to comment #5)
> I should mention that I've thought of one drawback: add-ons which add things to
> the actual browser content now have to check (on receiving conversation-loaded)
> that they don't add it twice.

If we run into problems we can put the information that this conversation has been loaded before into the data object of the notification.

Comment 9

[Patrick Cloke [:clokep]]

*** Original post on bio 1175 at 2013-05-31 00:38:48 UTC ***

http://hg.instantbird.org/instantbird/rev/c25d057274df

Comment 10

[aleth [:aleth]]

*** Original post on bio 1175 at 2013-05-31 10:43:52 UTC ***

(In reply to comment #7)
> If we run into problems we can put the information that this conversation has
> been loaded before into the data object of the notification.

This sounds a like a great solution and avoids having to introduce a separate notification (which I was hoping to avoid).

Want to add a followup with what you had in mind?