954650 - Search API queries need some escaping

Status: RESOLVED FIXED

(Chat Core :: Twitter, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1218 at 2012-01-02 18:36:00 UTC ***

Warning: sending request to http://search.twitter.com/search.json?q=#fail&since_id=153821308789071873 (POSTData = )
Source File: resource:///modules/http.jsm
Line: 110
Source Code:
xhr: doXHRequest

Warning: Received response: {"error":"You must enter a query."}
Source File: resource:///modules/http.jsm
Line: 80
Source Code:
xhr

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Simple fix v1

*** Original post on bio 1218 as attmnt 1121 at 2012-01-16 21:15:00 UTC ***

This simply percent encodes the get parameters we send for the track keyword.

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Simpler fix v2

*** Original post on bio 1218 as attmnt 1122 at 2012-01-16 22:10:00 UTC ***

This does a pure encodeURIComponent instead of the extra percent encodings (which seems to be what twitter.com/search uses).

flo suggested using encodeURIComponent(track).split(","), but that doesn't work because , is percent encoded into %2C. This seemed to be the easiest solution.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8352864 [details] [diff] [review]
Simple fix v1

*** Original change on bio 1218 attmnt 1121 at 2012-01-16 22:10:56 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8352865 [details] [diff] [review]
Simpler fix v2

*** Original change on bio 1218 attmnt 1122 at 2012-06-10 20:41:21 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Patrick Cloke [:clokep]]

*** Original post on bio 1218 at 2012-06-10 21:06:12 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/7bfe729f1a58