Closed Bug 954667 Opened 8 years ago Closed 8 years ago

sortComparator is sometimes called with the contact element instead of the contact object

Categories

(Instantbird :: Contacts window, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(1 file)

*** Original post on bio 1235 at 2012-01-14 21:59:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Blocks: 954206
Attached patch Fix v1Splinter Review
*** Original post on bio 1235 as attmnt 1119 at 2012-01-14 21:59:00 UTC ***

bug 954206 (bio 772) caused a slight regression where sometimes the group tries to compare a XUL element to a contact object, I think they both have a "displayName" property so it works OK, but it doesn't work for an extension I'm writing for bug 954136 (bio 701).

The fix is simple and attached. :) (Took a while to find though!)
Attachment #8352862 - Flags: review?(florian)
Comment on attachment 8352862 [details] [diff] [review]
Fix v1

*** Original change on bio 1235 attmnt 1119 at 2012-01-15 22:59:56 UTC ***

Looks good! :)
Attachment #8352862 - Flags: review?(florian) → review+
*** Original post on bio 1235 at 2012-01-15 23:08:46 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/8cf5eb2a5ae6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.