Closed
Bug 954742
Opened 11 years ago
Closed 11 years ago
Do not log channel keys when sending the JOIN command
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file)
|
799 bytes,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1310 at 2012-03-02 12:58:00 UTC ***
Currently when sending a JOIN command, the send command will go to the error console, we should treat this like the PASS command and override the logged message.
|
Assignee | |
Comment 1•11 years ago
|
||
*** Original post on bio 1310 as attmnt 1666 at 2012-06-23 13:35:00 UTC ***
I'd like to fix this before we release, there's certainly a privacy aspect to it.
Attachment #8353423 -
Flags: review?(bugzilla)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → clokep
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8353423 [details] [diff] [review]
Patch
*** Original change on bio 1310 attmnt 1666 at 2012-06-23 13:43:20 UTC ***
Good catch!
Attachment #8353423 -
Flags: review?(bugzilla) → review+
|
|
||
Updated•11 years ago
|
Whiteboard: [checkin-needed]
|
|
Assignee | |
Comment 3•11 years ago
|
||
*** Original post on bio 1310 at 2012-06-24 01:33:07 UTC ***
Committed as http://hg.instantbird.org/instantbird/rev/6519febff7ea
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•