954771 - Connect button is disabled after an account spends more than half a second in the disconnecting state

Status: RESOLVED FIXED

(Instantbird Graveyard :: Account manager, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1338 at 2012-03-15 14:25:00 UTC ***

Very visible with JS-IRC...

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1338 as attmnt 1692 at 2012-06-25 15:27:00 UTC ***

Can't see a prettier way of doing this...

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 1338 at 2012-06-25 15:32:33 UTC ***

I remember suggesting an easier solution on IRC: just always disable/reenable both buttons at once. Would that work?

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8353449 [details] [diff] [review]
Patch

*** Original change on bio 1338 attmnt 1692 at 2012-06-25 15:33:26 UTC ***

I really don't know this code.

Comment 4

[aleth [:aleth]]

*** Original post on bio 1338 at 2012-06-25 15:35:49 UTC ***

(In reply to comment #2)
> I remember suggesting an easier solution on IRC: just always disable/reenable
> both buttons at once. Would that work?

I'm not sure I understand.

The problem as I saw it is that when connecting, we want the Disconnect button to be enabled only after a brief delay, to avoid double-click errors (but no later, so we can abort connecting). When disconnecting, we want the Connect button to be enabled only after a delay AND when the account has actually disconnected.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8353449 [details] [diff] [review]
Patch

*** Original change on bio 1338 attmnt 1692 at 2012-08-03 13:37:54 UTC ***

I don't remember exactly what the idea I had to handle this was, but this patch has more setTimeout calls than reasonable. Especially the _buttonTimer callback calling itself again with a timeout seems wrong.

Comment 6

[Florian Quèze [:florian]]

Attachment: Patch

*** Original post on bio 1338 as attmnt 1780 at 2012-08-03 16:08:00 UTC ***

Patch following my suggestion of comment 2.

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8353449 [details] [diff] [review]
Patch

*** Original change on bio 1338 attmnt 1692 at 2012-08-03 16:08:54 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 8

[aleth [:aleth]]

Comment on attachment 8353541 [details] [diff] [review]
Patch

*** Original change on bio 1338 attmnt 1780 at 2012-08-03 17:09:28 UTC ***

Simplifies the previously convoluted code and works well :)

Comment 9

[Florian Quèze [:florian]]

Attachment: Follow-up addressing mconley's suggestion

*** Original post on bio 1338 as attmnt 1788 at 2012-08-04 22:43:00 UTC ***

Mike reviewed the same patch for Thunderbird and suggested some further simplification of the code: https://bugzilla.mozilla.org/show_bug.cgi?id=780173#c1

Comment 10

[Florian Quèze [:florian]]

*** Original post on bio 1338 at 2012-08-04 22:44:08 UTC ***

The fix as landed as https://hg.instantbird.org/instantbird/rev/871e12a7e1cf and I don't think this needs to stay open for the follow-up, so resolving as FIXED.

Comment 11

[aleth [:aleth]]

Comment on attachment 8353547 [details] [diff] [review]
Follow-up addressing mconley's suggestion

*** Original change on bio 1338 attmnt 1788 at 2012-08-05 20:08:47 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 12

[Florian Quèze [:florian]]

*** Original post on bio 1338 at 2012-08-21 13:46:21 UTC ***

Follow-up checked-in as https://hg.instantbird.org/instantbird/rev/fecf533aba2c (after the 1.2 release, so it will be in 1.3).