Closed Bug 954859 Opened 10 years ago Closed 10 years ago

Warning: GenericConvChatPrototype _init "setting a property that has only a getter"

Categories

(Chat Core :: General, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

Details

(Whiteboard: [1.2-wanted][regression])

Attachments

(1 file)

*** Original post on bio 1424 at 2012-05-05 11:00:00 UTC ***

Warning: setting a property that has only a getter
Source File: resource:///modules/jsProtoHelper.jsm
Line: 498
*** Original post on bio 1424 at 2012-05-05 13:27:08 UTC ***

Hmmm...well this.nick seems to have both a getter and a setter: http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#520

Perhaps we're overriding this somewhere though. :(
*** Original post on bio 1424 at 2012-05-06 08:19:38 UTC ***

It's a regression from bug 954746 (bio 1314) that hasn't handled the twitter special case: http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#356
Whiteboard: [1.2-wanted][regression]
Attached patch PatchSplinter Review
*** Original post on bio 1424 as attmnt 1556 at 2012-06-02 18:03:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353311 - Flags: review?(clokep)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8353311 [details] [diff] [review]
Patch

*** Original change on bio 1424 attmnt 1556 at 2012-06-02 18:11:16 UTC ***

This looks OK to me. Do we want to throw or something inside the setter?
Attachment #8353311 - Flags: review?(clokep) → review+
*** Original post on bio 1424 at 2012-06-02 18:13:19 UTC ***

(In reply to comment #4)
> Do we want to throw or something inside the setter?

I don't think so, it's just getting called by the _init method.
Whiteboard: [1.2-wanted][regression] → [1.2-wanted][regression][checkin-needed]
*** Original post on bio 1424 at 2012-06-03 04:55:07 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/0c3f8e1700b1

Thanks for fixing this! :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.2-wanted][regression][checkin-needed] → [1.2-wanted][regression]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.