954871 - Remove Welcome screen from Account wizard

Status: RESOLVED FIXED

(Instantbird Graveyard :: Account wizard, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1437 at 2012-05-17 18:11:00 UTC ***

It's an unnecessary extra step ("This wizard will help you in the process of setting up your IM account" is self-evident when the user has just clidked "New Account").

If a "Welcome to Instantbird" screen is wanted, that would be best placed in a first-run setting for a new profile.

Comment 1

[shrihari]

Attachment: Fix - Removed the Welcome screen from the Account wizard

Comment 2

[aleth [:aleth]]

Comment on attachment 8384535 [details] [diff] [review]
Fix - Removed the Welcome screen from the Account wizard

Review of attachment 8384535 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks!

::: im/content/accountWizard.js
@@ +30,1 @@
>      }

Coding style nit: You don't need {...} around a single line.

Comment 3

[shrihari]

Attachment: Bug 954871 - bug description, r=aleth

Comment 4

[aleth [:aleth]]

Comment on attachment 8384583 [details] [diff] [review]
Bug 954871 - bug description, r=aleth

># HG changeset patch
># Parent 992e6737ead5a3874a1555ff5e62cb24f600d757
># User Shrihari Sankaran <[e-mail]>
>Removed {...} around the single line

The preceding line (set with hg qref -e) should contain the commit message, which you instead put in the BMO patch description.

Comment 5

[shrihari]

Attachment: Removed the Welcome Screen from Account wizard

Comment 6

[aleth [:aleth]]

Comment on attachment 8384588 [details] [diff] [review]
Removed the Welcome Screen from Account wizard

Thanks!

Comment 7

[aleth [:aleth]]

Comment on attachment 8384588 [details] [diff] [review]
Removed the Welcome Screen from Account wizard

># HG changeset patch
># Parent 9f75934c373d138ec5f74013609ecb827486d775
># User Shrihari Sankaran <[e-mail]>
>Bug 954871 - Remove Welcome screen from Account wizard, r=aleth

As discussed on IRC, please use either "description, r=xxx." or "description. r=xxx". We generally prefer the former for Instantbird.

Comment 8

[shrihari]

Attachment: Removed the Welcome Screen from Account wizard

Comment 9

[aleth [:aleth]]

Comment on attachment 8384627 [details] [diff] [review]
Removed the Welcome Screen from Account wizard

FYI, you can obsolete the previous patch at the same time as submitting a new patch -- there are checkboxes on that web page.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/494114662d88