954873 - Make unambiguous command prefixes work as command aliases

Status: RESOLVED FIXED

(Chat Core :: General, enhancement)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1439 at 2012-05-18 09:37:00 UTC ***

hg does this and it's quite nice. And it would allow us to get rid of the stupid /j command on IRC!

Not sure if this is a core bug in imCommands.js or a UI thing for  conversation.xml; filed it in Core for now.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch for core

*** Original post on bio 1439 as attmnt 1763 at 2012-08-01 00:16:00 UTC ***

I decided to implement this as part of the core commands service. I tested it a bit and it seems to work fine. :)

Comment 2

[aleth [:aleth]]

Comment on attachment 8353524 [details] [diff] [review]
Patch for core

*** Original change on bio 1439 attmnt 1763 at 2012-08-01 00:41:16 UTC ***

>+    // The commands doesn't exist, check if the given command is a partial match
>+    // to a single other command.
Typo here (commands -> command).

Nice use of recursion ;) Looks good!

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Patch for core v1.0.1

*** Original post on bio 1439 as attmnt 1764 at 2012-08-01 00:46:00 UTC ***

Carrying aleth's review forward.

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8353524 [details] [diff] [review]
Patch for core

*** Original change on bio 1439 attmnt 1763 at 2012-08-01 00:46:52 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Patrick Cloke [:clokep]]

*** Original post on bio 1439 at 2012-08-02 00:37:50 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/9e3a83b7f2bb