Closed Bug 954873 Opened 8 years ago Closed 8 years ago

Make unambiguous command prefixes work as command aliases

Categories

(Chat Core :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: clokep)

References

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1439 at 2012-05-18 09:37:00 UTC ***

hg does this and it's quite nice. And it would allow us to get rid of the stupid /j command on IRC!

Not sure if this is a core bug in imCommands.js or a UI thing for  conversation.xml; filed it in Core for now.
Attached patch Patch for core (obsolete) — Splinter Review
*** Original post on bio 1439 as attmnt 1763 at 2012-08-01 00:16:00 UTC ***

I decided to implement this as part of the core commands service. I tested it a bit and it seems to work fine. :)
Attachment #8353524 - Flags: review?(bugzilla)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Severity: normal → enhancement
OS: Other → All
Hardware: x86 → All
Comment on attachment 8353524 [details] [diff] [review]
Patch for core

*** Original change on bio 1439 attmnt 1763 at 2012-08-01 00:41:16 UTC ***

>+    // The commands doesn't exist, check if the given command is a partial match
>+    // to a single other command.
Typo here (commands -> command).

Nice use of recursion ;) Looks good!
Attachment #8353524 - Flags: review?(bugzilla) → review+
*** Original post on bio 1439 as attmnt 1764 at 2012-08-01 00:46:00 UTC ***

Carrying aleth's review forward.
Attachment #8353525 - Flags: review+
Comment on attachment 8353524 [details] [diff] [review]
Patch for core

*** Original change on bio 1439 attmnt 1763 at 2012-08-01 00:46:52 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353524 - Attachment is obsolete: true
Whiteboard: [checkin-needed]
*** Original post on bio 1439 at 2012-08-02 00:37:50 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/9e3a83b7f2bb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
Depends on: 955360
You need to log in before you can comment on or make changes to this bug.