Closed Bug 954876 Opened 8 years ago Closed 8 years ago

IRC messages that need a : for the last parameter broken

Categories

(Chat Core :: IRC, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1442 at 2012-05-18 10:42:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Blocks: 954803
Attached patch The fix (obsolete) — Splinter Review
*** Original post on bio 1442 as attmnt 1484 at 2012-05-18 10:42:00 UTC ***

I made a change in bug 954803 (bio 1369) to only provide the : for the last parameter of IRC messages if necessary (by checking if there's a space). There's another case where it's necessary: if the first letter of the string is a colon.

This adds this case.
Attachment #8353237 - Flags: review?
Comment on attachment 8353237 [details] [diff] [review]
The fix

*** Original change on bio 1442 attmnt 1484 at 2012-05-18 10:49:06 UTC ***

Haven't tested this, but it looks good :)
Attachment #8353237 - Flags: review? → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1442 at 2012-05-19 13:17:18 UTC ***

Additionally, the space detection algorithm doesn't work (as filed in bug 954878 (bio 1444)). This is really all part of the same bug so I'm making this more general and duping it. I have a new patch that fixes both coming up shortly.
Summary: IRC messages starting with a : and no spaces lose the : → IRC messages that need a : for the last parameter broken
Duplicate of this bug: 954878
Attached patch Patch v2Splinter Review
*** Original post on bio 1442 as attmnt 1485 at 2012-05-19 14:55:00 UTC ***

This fixes both the case where you start with a : and if you have spaces in it. slice returns an array (of one element in this case), so we need to grab the only element in it first.
Attachment #8353238 - Flags: review?(bugzilla)
Comment on attachment 8353237 [details] [diff] [review]
The fix

*** Original change on bio 1442 attmnt 1484 at 2012-05-19 14:55:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353237 - Attachment is obsolete: true
Comment on attachment 8353238 [details] [diff] [review]
Patch v2

*** Original change on bio 1442 attmnt 1485 at 2012-05-19 15:02:26 UTC ***

This one should work better :)
Attachment #8353238 - Flags: review?(bugzilla) → review+
*** Original post on bio 1442 at 2012-05-20 17:58:44 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/ee30357e62a1
Severity: normal → blocker
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
Severity: blocker → major
Duplicate of this bug: 954879
You need to log in before you can comment on or make changes to this bug.