Closed Bug 954932 Opened 8 years ago Closed 8 years ago

Avoid attempting to connect accounts while offline, and disconnect connecting accounts when going offline

Categories

(Chat Core :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

(Whiteboard: [1.2-wanted])

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 1499 at 2012-06-08 23:01:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Blocks: 954930
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1499 as attmnt 1577 at 2012-06-08 23:01:00 UTC ***

This is separated out from bug 954930 (bio 1497) - the parts that do not induce behaviour changes.

- Throw an error when trying to connect a JS protocol while offline, matching the libpurple behaviour
- Disconnected the account properly when going offline while accounts are connecting.
- Cancel any reconnection timers when going offline.
Attachment #8353333 - Flags: review?(florian)
No longer blocks: 954930
Blocks: 954930
*** Original post on bio 1499 at 2012-06-08 23:08:25 UTC ***

This seems ok, but I would like to look at it again tomorrow.
Whiteboard: [1.2-wanted]
*** Original post on bio 1499 at 2012-06-08 23:12:29 UTC ***

(In reply to comment #0)

> - Cancel any reconnection timers when going offline.
This will also reset the count of reconnection attempts, so that we start at 1s again the next time a connection of the account fails; even if there wasn't a timer running at the time we went offline.
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1499 as attmnt 1579 at 2012-06-08 23:19:00 UTC ***

Add back a Services.io.offline test that will be removed again by bug 954930 (bio 1497).
Attachment #8353335 - Flags: review?(florian)
Comment on attachment 8353333 [details] [diff] [review]
Patch

*** Original change on bio 1499 attmnt 1577 at 2012-06-08 23:19:05 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353333 - Attachment is obsolete: true
Attachment #8353333 - Flags: review?(florian)
Comment on attachment 8353335 [details] [diff] [review]
Patch

*** Original change on bio 1499 attmnt 1579 at 2012-06-10 20:26:46 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353335 - Flags: review?(florian) → review+
Attached patch PatchSplinter Review
*** Original post on bio 1499 as attmnt 1584 at 2012-06-10 20:41:00 UTC ***

Same patch, fixed line counts.
Attachment #8353341 - Flags: review?(florian)
Comment on attachment 8353335 [details] [diff] [review]
Patch

*** Original change on bio 1499 attmnt 1579 at 2012-06-10 20:41:28 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353335 - Attachment is obsolete: true
Assignee: nobody → aleth
Comment on attachment 8353341 [details] [diff] [review]
Patch

*** Original change on bio 1499 attmnt 1584 at 2012-06-10 20:44:42 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353341 - Flags: review?(florian) → review+
*** Original post on bio 1499 at 2012-06-10 21:06:41 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/6444fecdc522 Thanks for fixing this!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.