954932 - Avoid attempting to connect accounts while offline, and disconnect connecting accounts when going offline

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1499 at 2012-06-08 23:01:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1499 as attmnt 1577 at 2012-06-08 23:01:00 UTC ***

This is separated out from bug 954930 (bio 1497) - the parts that do not induce behaviour changes.

- Throw an error when trying to connect a JS protocol while offline, matching the libpurple behaviour
- Disconnected the account properly when going offline while accounts are connecting.
- Cancel any reconnection timers when going offline.

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 1499 at 2012-06-08 23:08:25 UTC ***

This seems ok, but I would like to look at it again tomorrow.

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 1499 at 2012-06-08 23:12:29 UTC ***

(In reply to comment #0)

> - Cancel any reconnection timers when going offline.
This will also reset the count of reconnection attempts, so that we start at 1s again the next time a connection of the account fails; even if there wasn't a timer running at the time we went offline.

Comment 4

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1499 as attmnt 1579 at 2012-06-08 23:19:00 UTC ***

Add back a Services.io.offline test that will be removed again by bug 954930 (bio 1497).

Comment 5

[aleth [:aleth]]

Comment on attachment 8353333 [details] [diff] [review]
Patch

*** Original change on bio 1499 attmnt 1577 at 2012-06-08 23:19:05 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8353335 [details] [diff] [review]
Patch

*** Original change on bio 1499 attmnt 1579 at 2012-06-10 20:26:46 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 7

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1499 as attmnt 1584 at 2012-06-10 20:41:00 UTC ***

Same patch, fixed line counts.

Comment 8

[aleth [:aleth]]

Comment on attachment 8353335 [details] [diff] [review]
Patch

*** Original change on bio 1499 attmnt 1579 at 2012-06-10 20:41:28 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 9

[Florian Quèze [:florian]]

Comment on attachment 8353341 [details] [diff] [review]
Patch

*** Original change on bio 1499 attmnt 1584 at 2012-06-10 20:44:42 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 10

[Patrick Cloke [:clokep]]

*** Original post on bio 1499 at 2012-06-10 21:06:41 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/6444fecdc522 Thanks for fixing this!