954934 - Twitter's stream should the the moz-chunked-text XHR responseType

Status: RESOLVED FIXED

(Chat Core :: Twitter, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1501 at 2012-06-10 10:17:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

*** Original post on bio 1501 as attmnt 1583 at 2012-06-10 10:17:00 UTC ***

This awesome (and completely undocumented) mozilla extension to XHR was added in https://bugzilla.mozilla.org/show_bug.cgi?id=687087

My understanding of it is that when setting responseType to moz-chunked-text, the responseText and responseBody attributes become unusable, and instead one should use the response attribute which contains only the new data received since the last progress event.

This simple change should help with memory usage when a twitter account stays connected for hours.

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8353340 [details] [diff] [review]
Patch

*** Original change on bio 1501 attmnt 1583 at 2012-06-10 18:53:23 UTC ***

Nice find. :)

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 1501 at 2012-06-10 21:03:58 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/2749a7494bb8