954951 - /invite doesn't work

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1519 at 2012-06-18 15:16:00 UTC ***

Produces 
Unhandled IRC message: :gravel.mozilla.org 461 aleth INVITE :Not enough parameters

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 1519 at 2012-06-18 15:21:33 UTC ***

My guess is that this just needs a .split(" ") on it.

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Patch

*** Original post on bio 1519 as attmnt 1671 at 2012-06-23 14:29:00 UTC ***

So this needed a bit more than just a split. :)

When someone sends an invite to a channel we're in, we receive:
:concrete.mozilla.org NOTICE @#testib2 :clokep_js invited clokep into the channel.

Which, I guess it would be nice to display, but is sent to the server tab. I'm not sure if we want to try to parse the NOTICE commands better (or attempt to put them into a channel...), what specific message made us banish it to the server tab again?

Comment 3

[aleth [:aleth]]

Comment on attachment 8353428 [details] [diff] [review]
Patch

*** Original change on bio 1519 attmnt 1671 at 2012-06-23 14:43:11 UTC ***

This does not handle the receiving case (the INVITE response) yet (marked TODO in the code). On the invite-sending side, this looks good.

>When someone sends an invite to a channel we're in, we receive:
>:concrete.mozilla.org NOTICE @#testib2 :clokep_js invited clokep into the
>channel.

I suspect the NOTICEs were banned to the server tab because they don't actually tell us *which* channel (thanks, IRC! :( ).

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Patch with INVITE handling

*** Original post on bio 1519 as attmnt 1672 at 2012-06-23 14:52:00 UTC ***

Same patch as before, but also handles INVITE.

Note that this now has string changes.

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8353428 [details] [diff] [review]
Patch

*** Original change on bio 1519 attmnt 1671 at 2012-06-23 14:52:18 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[aleth [:aleth]]

Comment on attachment 8353429 [details] [diff] [review]
Patch with INVITE handling

*** Original change on bio 1519 attmnt 1672 at 2012-06-23 15:59:43 UTC ***

This works well :)

r+ with an added "return true" in the 341 handler.

Comment 7

[aleth [:aleth]]

*** Original post on bio 1519 at 2012-06-23 16:01:44 UTC ***

(In reply to comment #3)
> I suspect the NOTICEs were banned to the server tab because they don't actually
> tell us *which* channel (thanks, IRC! :( ).

This was in error, sorry. So in principle we could parse these, if we wanted to. Not part of this bug I think though.

Comment 8

[Patrick Cloke [:clokep]]

Attachment: Patch with INVITE handling v2

*** Original post on bio 1519 as attmnt 1673 at 2012-06-23 16:02:00 UTC ***

Adding the missing return, good catch. :)

Comment 9

[Patrick Cloke [:clokep]]

Comment on attachment 8353429 [details] [diff] [review]
Patch with INVITE handling

*** Original change on bio 1519 attmnt 1672 at 2012-06-23 16:02:57 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 10

[aleth [:aleth]]

Comment on attachment 8353430 [details] [diff] [review]
Patch with INVITE handling v2

*** Original change on bio 1519 attmnt 1673 at 2012-06-23 16:03:52 UTC ***

Ready to land I think :)

Comment 11

[Patrick Cloke [:clokep]]

*** Original post on bio 1519 at 2012-06-24 01:32:16 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/8ba81ec876ed