Closed Bug 954951 Opened 10 years ago Closed 10 years ago

/invite doesn't work

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: clokep)

References

Details

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 1519 at 2012-06-18 15:16:00 UTC ***

Produces 
Unhandled IRC message: :gravel.mozilla.org 461 aleth INVITE :Not enough parameters
*** Original post on bio 1519 at 2012-06-18 15:21:33 UTC ***

My guess is that this just needs a .split(" ") on it.
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1519 as attmnt 1671 at 2012-06-23 14:29:00 UTC ***

So this needed a bit more than just a split. :)

When someone sends an invite to a channel we're in, we receive:
:concrete.mozilla.org NOTICE @#testib2 :clokep_js invited clokep into the channel.

Which, I guess it would be nice to display, but is sent to the server tab. I'm not sure if we want to try to parse the NOTICE commands better (or attempt to put them into a channel...), what specific message made us banish it to the server tab again?
Attachment #8353428 - Flags: review?(bugzilla)
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8353428 [details] [diff] [review]
Patch

*** Original change on bio 1519 attmnt 1671 at 2012-06-23 14:43:11 UTC ***

This does not handle the receiving case (the INVITE response) yet (marked TODO in the code). On the invite-sending side, this looks good.

>When someone sends an invite to a channel we're in, we receive:
>:concrete.mozilla.org NOTICE @#testib2 :clokep_js invited clokep into the
>channel.

I suspect the NOTICEs were banned to the server tab because they don't actually tell us *which* channel (thanks, IRC! :( ).
Attachment #8353428 - Flags: review?(bugzilla) → review-
Attached patch Patch with INVITE handling (obsolete) — Splinter Review
*** Original post on bio 1519 as attmnt 1672 at 2012-06-23 14:52:00 UTC ***

Same patch as before, but also handles INVITE.

Note that this now has string changes.
Attachment #8353429 - Flags: review?(bugzilla)
Comment on attachment 8353428 [details] [diff] [review]
Patch

*** Original change on bio 1519 attmnt 1671 at 2012-06-23 14:52:18 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353428 - Attachment is obsolete: true
Comment on attachment 8353429 [details] [diff] [review]
Patch with INVITE handling

*** Original change on bio 1519 attmnt 1672 at 2012-06-23 15:59:43 UTC ***

This works well :)

r+ with an added "return true" in the 341 handler.
Attachment #8353429 - Flags: review?(bugzilla) → review-
*** Original post on bio 1519 at 2012-06-23 16:01:44 UTC ***

(In reply to comment #3)
> I suspect the NOTICEs were banned to the server tab because they don't actually
> tell us *which* channel (thanks, IRC! :( ).

This was in error, sorry. So in principle we could parse these, if we wanted to. Not part of this bug I think though.
*** Original post on bio 1519 as attmnt 1673 at 2012-06-23 16:02:00 UTC ***

Adding the missing return, good catch. :)
Attachment #8353430 - Flags: review?(bugzilla)
Comment on attachment 8353429 [details] [diff] [review]
Patch with INVITE handling

*** Original change on bio 1519 attmnt 1672 at 2012-06-23 16:02:57 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353429 - Attachment is obsolete: true
Comment on attachment 8353430 [details] [diff] [review]
Patch with INVITE handling v2

*** Original change on bio 1519 attmnt 1673 at 2012-06-23 16:03:52 UTC ***

Ready to land I think :)
Attachment #8353430 - Flags: review?(bugzilla) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 1519 at 2012-06-24 01:32:16 UTC ***

Checked in as http://hg.instantbird.org/instantbird/rev/8ba81ec876ed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
Depends on: 954990
You need to log in before you can comment on or make changes to this bug.