Allow using a custom username for IRC.

RESOLVED FIXED in 1.2

Status

--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
*** Original post on bio 1534 at 2012-06-21 02:17:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
(Assignee)

Comment 1

5 years ago
Created attachment 8353413 [details] [diff] [review]
Patch v1

*** Original post on bio 1534 as attmnt 1656 at 2012-06-21 02:17:00 UTC ***

As requested by Mook: allow using a custom username (instead of brandShortName, e.g. Instantbird or Thunderbird) by using a hidden pref on the account: "username". Note that this also matches the old libpurple pref name, so it should make migration make more sense.

I'd really rather not expose this to the user, but I have no issue supporting it in the backend.

And because you requested it Mook, you get to review it.
Attachment #8353413 - Flags: review?(bugzilla)

Comment 2

5 years ago
Comment on attachment 8353413 [details] [diff] [review]
Patch v1

*** Original change on bio 1534 attmnt 1656 by mook.moz+bugs.instantbird AT gmail.com at 2012-06-21 03:27:10 UTC ***

Thanks!
This is once of those places where if getString just returned undefined for missing prefs, it would be cleaner:
let username = this.getString("username") || l10nHelper("...")("brandshortName");
(which would catch the case where the user manually set it to an empty string)

... actually, just think about the empty string case and make sure it's allowable per spec, even for your existing change, please :)
Attachment #8353413 - Flags: review?(bugzilla) → review+
*** Original post on bio 1534 at 2012-06-21 09:14:03 UTC ***

(In reply to comment #1)

> ... actually, just think about the empty string case and make sure it's
> allowable per spec, even for your existing change, please :)

So you r+'ed, but it's actually an r-, right? ;)
(Assignee)

Comment 4

5 years ago
Created attachment 8353414 [details] [diff] [review]
Patch v2

*** Original post on bio 1534 as attmnt 1657 at 2012-06-21 10:36:00 UTC ***

Good call on the empty username. This avoids that situation.
Attachment #8353414 - Flags: review?(bugzilla)
(Assignee)

Comment 5

5 years ago
Comment on attachment 8353413 [details] [diff] [review]
Patch v1

*** Original change on bio 1534 attmnt 1656 at 2012-06-21 10:36:11 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353413 - Attachment is obsolete: true

Comment 6

5 years ago
Comment on attachment 8353414 [details] [diff] [review]
Patch v2

*** Original change on bio 1534 attmnt 1657 by mook.moz+bugs.instantbird AT gmail.com at 2012-06-21 16:11:54 UTC ***

Flo: it was a r+ but make sure condition X was considered :)
Attachment #8353414 - Flags: review?(bugzilla) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [checkin-needed]
(Assignee)

Comment 7

5 years ago
*** Original post on bio 1534 at 2012-06-24 01:30:26 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/9134c46bae1b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.