955046 - Unread ruler in split bubble just before an action message hides the sender name

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1616 at 2012-08-03 11:25:00 UTC ***

The message following the ruler is displayed "*** is unsure...". 
Only when the unread ruler disappears, it becomes "*** aleth is unsure..."

Comment 1

[aleth [:aleth]]

*** Original post on bio 1616 at 2012-08-03 13:19:00 UTC ***

This is due to getHTMLForMessage replacing the /me in the message with the sender name the first time it is called. On the second call, it therefore does not recognize it should replace %message% with the infolist value from the message style.

Comment 2

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1616 as attmnt 1779 at 2012-08-03 15:06:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8353540 [details] [diff] [review]
Patch

*** Original change on bio 1616 attmnt 1779 at 2012-08-03 15:56:08 UTC ***

Looks ok, but please add a comment explaining why we are doing this, as the code after the modification looks really like someone meant to test the the string he's going to make a replacement on ;).

Comment 4

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1616 as attmnt 1781 at 2012-08-03 17:10:00 UTC ***

Adds comment

Comment 5

[aleth [:aleth]]

Comment on attachment 8353540 [details] [diff] [review]
Patch

*** Original change on bio 1616 attmnt 1779 at 2012-08-03 17:10:07 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8353542 [details] [diff] [review]
Patch

*** Original change on bio 1616 attmnt 1781 at 2012-08-03 18:03:08 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 7

[Patrick Cloke [:clokep]]

*** Original post on bio 1616 at 2012-08-03 18:11:57 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/0c4d8120606e

Thanks!