Unread ruler in split bubble just before an action message hides the sender name

RESOLVED FIXED in 1.2

Status

Instantbird
Conversation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

853 bytes, patch
florian
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
*** Original post on bio 1616 at 2012-08-03 11:25:00 UTC ***

The message following the ruler is displayed "*** is unsure...". 
Only when the unread ruler disappears, it becomes "*** aleth is unsure..."
(Assignee)

Updated

4 years ago
OS: Linux → All
Hardware: x86 → All
(Assignee)

Updated

4 years ago
Summary: Bubbles: Unread ruler in split bubble just before an action message hides the sender name → Unread ruler in split bubble just before an action message hides the sender name
(Assignee)

Comment 1

4 years ago
*** Original post on bio 1616 at 2012-08-03 13:19:00 UTC ***

This is due to getHTMLForMessage replacing the /me in the message with the sender name the first time it is called. On the second call, it therefore does not recognize it should replace %message% with the infolist value from the message style.
(Assignee)

Comment 2

4 years ago
Created attachment 8353540 [details] [diff] [review]
Patch

*** Original post on bio 1616 as attmnt 1779 at 2012-08-03 15:06:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353540 - Flags: review?(florian)
(Assignee)

Updated

4 years ago
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8353540 [details] [diff] [review]
Patch

*** Original change on bio 1616 attmnt 1779 at 2012-08-03 15:56:08 UTC ***

Looks ok, but please add a comment explaining why we are doing this, as the code after the modification looks really like someone meant to test the the string he's going to make a replacement on ;).
Attachment #8353540 - Flags: review?(florian) → review-
(Assignee)

Comment 4

4 years ago
Created attachment 8353542 [details] [diff] [review]
Patch

*** Original post on bio 1616 as attmnt 1781 at 2012-08-03 17:10:00 UTC ***

Adds comment
Attachment #8353542 - Flags: review?(florian)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8353540 [details] [diff] [review]
Patch

*** Original change on bio 1616 attmnt 1779 at 2012-08-03 17:10:07 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353540 - Attachment is obsolete: true
Comment on attachment 8353542 [details] [diff] [review]
Patch

*** Original change on bio 1616 attmnt 1781 at 2012-08-03 18:03:08 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353542 - Flags: review?(florian) → review+
*** Original post on bio 1616 at 2012-08-03 18:11:57 UTC ***

Committed as http://hg.instantbird.org/instantbird/rev/0c4d8120606e

Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.