955118 - /whois in a private irc conversation should support being parameterless

Status: RESOLVED FIXED

(Chat Core :: IRC, enhancement)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 1690 at 2012-09-07 15:44:00 UTC ***

Typing /whois without parameter in a private irc conversation to see
more info about the nick talking to you.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch

*** Original post on bio 1690 as attmnt 2183 at 2013-01-08 01:06:00 UTC ***

Fairly simple patch for this. If it isn't a chat, we request information on the conversation name.

Comment 2

[aleth [:aleth]]

Comment on attachment 8353945 [details] [diff] [review]
Patch

*** Original change on bio 1690 attmnt 2183 at 2013-01-17 11:11:05 UTC ***

Just a nit: If whois was passed multiple parameters, I think we should still return false and not return whois info for the conversation nick, as whatever the user intended, it was not that.

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Patch v2

*** Original post on bio 1690 as attmnt 2199 at 2013-01-17 11:38:00 UTC ***

This explicitly checks for multiple parameters and returns false. I couldn't think of a way to further reduce the logic in here, but if you can...let me know!

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8353945 [details] [diff] [review]
Patch

*** Original change on bio 1690 attmnt 2183 at 2013-01-17 11:38:09 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Patch v3

*** Original post on bio 1690 as attmnt 2200 at 2013-01-17 11:58:00 UTC ***

Without the nick.contains, aleth said this won't work until Moz 18 (which my local build is on).

Comment 6

[Patrick Cloke [:clokep]]

Comment on attachment 8353962 [details] [diff] [review]
Patch v2

*** Original change on bio 1690 attmnt 2199 at 2013-01-17 11:58:51 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 7

[aleth [:aleth]]

Comment on attachment 8353963 [details] [diff] [review]
Patch v3

*** Original change on bio 1690 attmnt 2200 at 2013-01-17 12:03:58 UTC ***

>+      if (nick.indexOf(" ") != 0)
>         return false;
A typo I think...

Comment 8

[Patrick Cloke [:clokep]]

Attachment: Patch v3.1

*** Original post on bio 1690 as attmnt 2201 at 2013-01-17 12:06:00 UTC ***

Searches for -1, not 0.

Comment 9

[Patrick Cloke [:clokep]]

Comment on attachment 8353963 [details] [diff] [review]
Patch v3

*** Original change on bio 1690 attmnt 2200 at 2013-01-17 12:06:09 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 10

[aleth [:aleth]]

Comment on attachment 8353964 [details] [diff] [review]
Patch v3.1

*** Original change on bio 1690 attmnt 2201 at 2013-01-17 12:07:35 UTC ***

Thanks for this improvement!

Comment 11

[Patrick Cloke [:clokep]]

Attachment: Patch v3.2

*** Original post on bio 1690 as attmnt 2204 at 2013-01-19 04:17:00 UTC ***

Change the property name & doesn't rename aMsg to nick. This should probably get reviewed by someone again.

Comment 12

[Patrick Cloke [:clokep]]

Comment on attachment 8353964 [details] [diff] [review]
Patch v3.1

*** Original change on bio 1690 attmnt 2201 at 2013-01-19 04:17:16 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 13

[aleth [:aleth]]

Comment on attachment 8353967 [details] [diff] [review]
Patch v3.2

*** Original change on bio 1690 attmnt 2204 at 2013-01-19 10:16:43 UTC ***

Sorry I missed the string change issue.

Comment 14

[aleth [:aleth]]

*** Original post on bio 1690 at 2013-01-19 12:37:25 UTC ***

http://hg.instantbird.org/instantbird/rev/8b44e1abd23f