Closed
Bug 955137
Opened 11 years ago
Closed 11 years ago
Remove purple specific property from prplIChatRoomFieldValues
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file, 1 obsolete file)
|
2.26 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1709 at 2012-09-26 23:43:00 UTC ***
*** Due to BzAPI limitations, the initial description is in comment 1 ***
|
Assignee | |
Comment 1•11 years ago
|
||
*** Original post on bio 1709 as attmnt 1916 at 2012-09-26 23:43:00 UTC ***
purpleIChatRoomFieldValues has a gHashTable property which is only used in purplexpcom, it should be moved to the C++ class.
Attachment #8353674 -
Flags: review?(florian)
|
|
Assignee | |
Comment 2•11 years ago
|
||
*** Original post on bio 1709 as attmnt 1917 at 2012-09-26 23:58:00 UTC ***
Fixes the receive comments from IRC.
Attachment #8353675 -
Flags: review?(florian)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8353674 [details] [diff] [review]
Patch
*** Original change on bio 1709 attmnt 1916 at 2012-09-26 23:58:47 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353674 -
Attachment is obsolete: true
Attachment #8353674 -
Flags: review?(florian)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8353675 [details] [diff] [review]
Patch v2.1
*** Original change on bio 1709 attmnt 1917 at 2012-10-02 20:49:29 UTC ***
Thanks for cleaning this up! :-)
Attachment #8353675 -
Flags: review?(florian) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
*** Original post on bio 1709 at 2012-10-02 22:32:05 UTC ***
Fixed in http://hg.instantbird.org/instantbird/rev/5e567773ac96
Severity: normal → trivial
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
OS: Other → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•