Closed
Bug 955155
Opened 10 years ago
Closed 10 years ago
Part and join system messages are asymmetric
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file, 1 obsolete file)
2.58 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1726 at 2012-10-15 20:51:00 UTC *** /parting a channel leads to the system message "You have left the room (Part).", while /joining a channel we have parted is silent. We might want to add a "You have rejoined the room" system message to provide more visible user feedback than the tab icon changing. (The complication is to add this additional message only when we are rejoining the room, so as not to add unnecessary noise when it is not needed). Alternatively, we could remove the /part system message for the case where it is the user that leaves the room (rather than some other participant). This would also restore symmetry.
Comment 1•10 years ago
|
||
*** Original post on bio 1726 at 2012-10-15 20:53:42 UTC *** The message should be added. You'd have to check somewhere in http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircBase.jsm#198 if the channel existed already or not.
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1726 as attmnt 1968 at 2012-10-16 18:17:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353727 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8353727 [details] [diff] [review] Patch *** Original change on bio 1726 attmnt 1968 at 2012-10-16 18:33:21 UTC *** >diff --git a/chrome/en-US/locale/en-US/chat/irc.properties b/chrome/en-US/locale/en-US/chat/irc.properties > # LOCALIZATION NOTE (message.*): > # These are shown as system messages in the conversation. > # %1$S is the nick and %2$S is the nick and host of the user who joined. > message.join=%1$S [%2$S] entered the room. >+message.rejoined=You have rejoined the room. Seems weird that one of these says "entered" and the other says "rejoined"...but I'm not sure "re-entered" looks better. >+// If the user parted from this room earlier, confirm the rejoin. >+if (convAlreadyExists && !conversation._chatRoomFields) { I think !conversation._chatRoomFields is checking whether it was automatically rejoined. I'd like this to be explained in the comment.
Attachment #8353727 -
Flags: review?(clokep) → review-
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1726 as attmnt 1969 at 2012-10-16 18:41:00 UTC *** (In reply to comment #3) > > message.join=%1$S [%2$S] entered the room. > >+message.rejoined=You have rejoined the room. > Seems weird that one of these says "entered" and the other says > "rejoined"...but I'm not sure "re-entered" looks better. Re-entered reminds me of spaceships... "Rejoined" looks odd in the context of irc.properties, but when such a rejoin actually happens, it is due to the user using "/join", or "Join Chat", so it fits.
Attachment #8353728 -
Flags: review?(clokep)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8353727 [details] [diff] [review] Patch *** Original change on bio 1726 attmnt 1968 at 2012-10-16 18:41:30 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353727 -
Attachment is obsolete: true
Comment 6•10 years ago
|
||
Comment on attachment 8353728 [details] [diff] [review] Patch *** Original change on bio 1726 attmnt 1969 at 2012-10-16 19:09:52 UTC *** Thanks for the verbose comment. :)
Attachment #8353728 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 7•10 years ago
|
||
*** Original post on bio 1726 at 2012-10-26 10:21:24 UTC *** Checked in as http://hg.instantbird.org/instantbird/rev/0b9a66047bcb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•