Closed
Bug 955166
Opened 10 years ago
Closed 10 years ago
Shutdown leak if there are opened conversations at shutdown
Categories
(Instantbird Graveyard :: Conversation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
820 bytes,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1735 at 2012-10-21 11:21:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1735 as attmnt 2000 at 2012-10-21 11:21:00 UTC *** When closing all conversations before quitting a debug Instantbird, there's no shutdown leak at the end. If a conversation window is still opened at shutdown, there's this JS error: JavaScript strict warning: file:///Users/florian/buildhg/obj-instantbird-dbg/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imConversations.js, line 47: reference to undefined property this._purpleConv[this._currentTargetId] JavaScript error: chrome://instantbird/content/conversation.xml, line 94: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "this.target is undefined" {file: "file:///Users/florian/buildhg/obj-instantbird-dbg/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imConversations.js" line: 267}]' when calling method: [imIConversation::isChat] Calling .isChat() on an imConversation is no longer possible after the imConversations service has been uninitialized.
Attachment #8353759 -
Flags: review?(bugzilla)
Comment 2•10 years ago
|
||
Comment on attachment 8353759 [details] [diff] [review] Fix *** Original change on bio 1735 attmnt 2000 at 2012-10-21 12:32:56 UTC *** Sorry - should have tested what actually happens on shutdown, rather than just assuming it's like closing a conversation.
Attachment #8353759 -
Flags: review?(bugzilla) → review+
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 3•10 years ago
|
||
*** Original post on bio 1735 at 2012-10-25 12:06:56 UTC *** Fixed in http://hg.instantbird.org/instantbird/rev/fa89c6203845
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•