Closed
Bug 955186
Opened 10 years ago
Closed 10 years ago
No location information for messages logged from imXPCOMUtils
Categories
(Chat Core :: Debug, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: florian, Assigned: florian)
References
Details
(Whiteboard: [1.3-blocking][regression])
Attachments
(1 file)
808 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1754 at 2012-11-04 17:48:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1754 as attmnt 2041 at 2012-11-04 17:48:00 UTC *** I added a dump(caller) call just after the "let caller = Components.stack.caller;" line and it prints: native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 I don't know where that native frame comes from, but if I use Components.stack.caller.caller instead of Components.stack.caller the bug disappears.
Attachment #8353801 -
Flags: review?
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.3-blocking][regression]
Comment 2•10 years ago
|
||
Comment on attachment 8353801 [details] [diff] [review] Patch *** Original change on bio 1754 attmnt 2041 at 2012-11-05 01:52:39 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353801 -
Flags: review? → review+
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1754 at 2012-11-05 01:57:23 UTC *** We will want unit tests for this, but let's unbreak it first! Thanks for the quick review. http://hg.instantbird.org/instantbird/rev/a9346a5e39a7
Assignee | ||
Comment 4•10 years ago
|
||
*** Original post on bio 1754 at 2012-11-05 23:39:35 UTC *** (In reply to comment #1) > We will want unit tests for this, but let's unbreak it first! I filed bug 955202 (bio 1770) for adding unit tests. That obviously doesn't block 1.3, so let's resolve this.
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•