Closed
Bug 955197
Opened 10 years ago
Closed 10 years ago
Ensure authentication on reconnect
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: aleth, Assigned: aleth)
References
Details
(Whiteboard: [1.3-blocking][regression])
Attachments
(1 file, 1 obsolete file)
893 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1765 at 2012-11-05 17:18:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1765 as attmnt 2051 at 2012-11-05 17:18:00 UTC *** Clears the isAuthenticated flag when we are disconnected.
Attachment #8353811 -
Flags: review?(clokep)
Comment 2•10 years ago
|
||
Comment on attachment 8353811 [details] [diff] [review] Patch *** Original change on bio 1765 attmnt 2051 at 2012-11-05 19:41:18 UTC *** Please delete this.isAuthenticated, not set it to false. Also, please put a comment saying that we want to be able to reauthenticate.
Attachment #8353811 -
Flags: review?(clokep) → review-
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1765 as attmnt 2054 at 2012-11-05 20:03:00 UTC *** I have an irrational aversion to setting booleans to false by deleting them ;)
Attachment #8353814 -
Flags: review?(clokep)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8353811 [details] [diff] [review] Patch *** Original change on bio 1765 attmnt 2051 at 2012-11-05 20:03:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353811 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 5•10 years ago
|
||
Comment on attachment 8353814 [details] [diff] [review] Patch *** Original change on bio 1765 attmnt 2054 at 2012-11-05 20:05:58 UTC *** Looks good, thanks!
Attachment #8353814 -
Flags: review?(clokep) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.3-blocking][regression] → [1.3-blocking][regression][checkin-needed]
Comment 6•10 years ago
|
||
*** Original post on bio 1765 at 2012-11-06 10:32:41 UTC *** http://hg.instantbird.org/instantbird/rev/0cb3c145197f
Whiteboard: [1.3-blocking][regression][checkin-needed] → [1.3-blocking][regression]
Target Milestone: --- → 1.3
Comment 7•10 years ago
|
||
*** Original post on bio 1765 at 2012-11-06 10:34:08 UTC *** Forgot to resolve... :(
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•