Closed
Bug 955209
Opened 11 years ago
Closed 11 years ago
Wait more than 1s before showing NickServ's messages
Categories
(Chat Core :: IRC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
|
770 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1777 at 2012-11-08 15:21:00 UTC ***
*** Due to BzAPI limitations, the initial description is in comment 1 ***
|
Assignee | |
Comment 1•11 years ago
|
||
*** Original post on bio 1777 as attmnt 2071 at 2012-11-08 15:21:00 UTC ***
On very slow connections, 1s isn't enough. Let's wait 10s instead.
Attachment #8353831 -
Flags: review?(clokep)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8353831 [details] [diff] [review]
Patch
*** Original change on bio 1777 attmnt 2071 at 2012-11-08 15:26:37 UTC ***
I think this is reasonable. Usually you have at least 30s to respond to NickServ, if we fail for some reason this would still give the user 20s to respond...although in that case our code failed anyway so...
But looks good, let's take this for 1.3.
Attachment #8353831 -
Flags: review?(clokep) → review+
|
|
||
Comment 3•11 years ago
|
||
*** Original post on bio 1777 at 2012-11-09 00:41:09 UTC ***
http://hg.instantbird.org/instantbird/rev/d6fa12d93126
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•