Closed
Bug 955221
Opened 10 years ago
Closed 10 years ago
Google Talk (JS-XMPP) accounts should timeout when the connection to the server has stalled
Categories
(Chat Core :: XMPP, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: florian, Assigned: florian)
References
Details
(Whiteboard: [1.3-blocking])
Attachments
(1 file)
3.20 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1789 at 2012-11-10 19:36:00 UTC *** I think we should both use a read/write timeout at the socket.jsm level for XMPP connections, and use XMPP iq-ping stanzas to keep the connection alive (http://xmpp.org/extensions/xep-0199.html). I propose that we do: - socket.jsm timeout of 5 minutes (just to be safe; that should never actually happen). - send an XMPP iq-ping every 2 minute if no data has been received. - disconnect and auto-reconnect the account 30s after sending an iq-ping if no reply arrives. I think we need this for 1.3.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.3-blocking]
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1789 as attmnt 2082 at 2012-11-11 17:45:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353842 -
Flags: review?(bugzilla)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florian
Comment 2•10 years ago
|
||
Comment on attachment 8353842 [details] [diff] [review] Patch *** Original change on bio 1789 attmnt 2082 at 2012-11-11 18:52:23 UTC *** This looks good to me and follows the spec (caveat emptor: I don't know much XMPP). Thanks for fixing this!
Attachment #8353842 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1789 at 2012-11-12 00:58:27 UTC *** http://hg.instantbird.org/instantbird/rev/33406ddc834d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•