955223 - Changing one's status retries to connect accounts for which the user clicked "Cancel reconnection"

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Florian Quèze [:florian]]

*** Original post on bio 1790 at 2012-11-11 22:03:00 UTC ***

Steps to reproduce:
1. Have an account that failed to connect with an error that triggers the auto-reconnect timers.
2. Cancel the reconnection attemps from the context menu of the account manager.
3. Change the status (or just become idle).

Expected result:
Becoming idle (or changing the status) shouldn't affect the account that's disconnected with an error and no longer trying to reconnect.

Actual result:
Immediately after changing the status, the account tries to connect again.

Comment 1

[Florian Quèze [:florian]]

Attachment: Untested patch

*** Original post on bio 1790 as attmnt 2084 at 2012-11-11 22:40:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 2

[aleth [:aleth]]

Comment on attachment 8353844 [details] [diff] [review]
Untested patch

*** Original change on bio 1790 attmnt 2084 at 2012-11-11 23:07:18 UTC ***

Tested with IRC and it works.

As discussed on IRC, cancelReconnection should throw if (!this.disconnected). r+ with this change.

Thanks for patching this so quickly :)

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 1790 at 2012-11-12 00:57:37 UTC ***

http://hg.instantbird.org/instantbird/rev/01c25cf5139b