Closed
Bug 955223
Opened 10 years ago
Closed 10 years ago
Changing one's status retries to connect accounts for which the user clicked "Cancel reconnection"
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
3.77 KB,
patch
|
aleth
:
review-
|
Details | Diff | Splinter Review |
*** Original post on bio 1790 at 2012-11-11 22:03:00 UTC *** Steps to reproduce: 1. Have an account that failed to connect with an error that triggers the auto-reconnect timers. 2. Cancel the reconnection attemps from the context menu of the account manager. 3. Change the status (or just become idle). Expected result: Becoming idle (or changing the status) shouldn't affect the account that's disconnected with an error and no longer trying to reconnect. Actual result: Immediately after changing the status, the account tries to connect again.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1790 as attmnt 2084 at 2012-11-11 22:40:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353844 -
Flags: review?(bugzilla)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florian
Comment 2•10 years ago
|
||
Comment on attachment 8353844 [details] [diff] [review] Untested patch *** Original change on bio 1790 attmnt 2084 at 2012-11-11 23:07:18 UTC *** Tested with IRC and it works. As discussed on IRC, cancelReconnection should throw if (!this.disconnected). r+ with this change. Thanks for patching this so quickly :)
Attachment #8353844 -
Flags: review?(bugzilla) → review-
Updated•10 years ago
|
OS: Other → All
Hardware: x86 → All
Whiteboard: [checkin-needed]
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1790 at 2012-11-12 00:57:37 UTC *** http://hg.instantbird.org/instantbird/rev/01c25cf5139b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•