Closed Bug 955275 Opened 10 years ago Closed 10 years ago

Add pref to set length of debug log.

Categories

(Chat Core :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

(Whiteboard: [1.4-wanted])

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 1842 at 2012-11-29 15:33:00 UTC ***

As discussed in bug 955260 (bio 1827).
Blocks: 955260
*** Original post on bio 1842 at 2012-11-29 15:35:14 UTC ***

>The "50" const could well be worth a hidden pref with a much higher default
>value for debug builds.
and a 0 (or negative?) value to allow unlimited log collection.
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 1842 as attmnt 2363 at 2013-04-15 12:52:00 UTC ***

Turns out 100 is not enough for a fresh connection to irc.mozilla.org plus connection to one channel.
Attachment #8354130 - Flags: review?(florian)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
*** Original post on bio 1842 at 2013-04-15 12:54:08 UTC ***

One question I had was whether the pref should live in chat.debuglogs.* rather than messenger.accounts.*.
Whiteboard: [1.4-wanted]
Attached patch PatchSplinter Review
*** Original post on bio 1842 as attmnt 2364 at 2013-04-15 13:52:00 UTC ***

Moves default pref value to /chat and adds comment.
Attachment #8354131 - Flags: review?(florian)
Comment on attachment 8354130 [details] [diff] [review]
Patch

*** Original change on bio 1842 attmnt 2363 at 2013-04-15 13:52:55 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354130 - Attachment is obsolete: true
Attachment #8354130 - Flags: review?(florian)
Comment on attachment 8354131 [details] [diff] [review]
Patch

*** Original change on bio 1842 attmnt 2364 at 2013-04-15 23:26:25 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354131 - Flags: review?(florian) → review+
*** Original post on bio 1842 at 2013-04-15 23:47:22 UTC ***

This will be a great addition, thanks!

http://hg.instantbird.org/instantbird/rev/b30f06233829
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.